Bug 13704

Summary: Typo in mesa patch causes build error
Product: [Build System, Metadata & Runtime] Meta-yocto Reporter: anon2313
Component: meta-yoctoAssignee: akuster <akuster808>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: Medium+ CC: akuster, poky.bs.watcher, poky.watcher, randy.macleod
Version: 3.0.1   
Target Milestone: 3.0.4   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Attachments:
Description Flags
type fixed in Yocto patch none

Description anon2313 2019-12-12 22:13:51 UTC
If you build Mesa without "dri" being enabled in PACKAGECONFIG then you get the following error:
meson.build:140:0: ERROR: Unknown variable "_drivers".

The file 0003-Allow-enable-DRI-without-DRI-drivers.patch has a typo in it.

-with_dri = dri_drivers.length() != 0 and dri_drivers != ['']
+with_dri = get_option('dri') or (_drivers.length() != 0 and _drivers != [''])

"_drivers" should be "dri_drivers".
Comment 1 Armin Kuster 2019-12-19 15:36:16 UTC
Are you will to send a patch?
Comment 2 anon2313 2019-12-19 18:02:24 UTC
I can attach what I changed, but I'm not sure how this should be formatted or where to send it to.
Comment 3 anon2313 2019-12-19 18:03:23 UTC
Created attachment 4606 [details]
type fixed in Yocto patch
Comment 5 akuster 2020-05-28 08:09:51 UTC
patch sent.

https://patchwork.openembedded.org/patch/172933/
Comment 7 akuster 2020-06-04 07:14:29 UTC
closing