Bug 13704 - Typo in mesa patch causes build error
Summary: Typo in mesa patch causes build error
Status: CLOSED FIXED
Alias: None
Product: Meta-yocto
Classification: Build System, Metadata & Runtime
Component: meta-yocto (show other bugs)
Version: 3.0.1
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 3.0.4
Assignee: akuster
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2019-12-12 22:13 UTC by anon2313
Modified: 2020-06-04 07:14 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
type fixed in Yocto patch (1.46 KB, patch)
2019-12-19 18:03 UTC, anon2313
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description anon2313 2019-12-12 22:13:51 UTC
If you build Mesa without "dri" being enabled in PACKAGECONFIG then you get the following error:
meson.build:140:0: ERROR: Unknown variable "_drivers".

The file 0003-Allow-enable-DRI-without-DRI-drivers.patch has a typo in it.

-with_dri = dri_drivers.length() != 0 and dri_drivers != ['']
+with_dri = get_option('dri') or (_drivers.length() != 0 and _drivers != [''])

"_drivers" should be "dri_drivers".
Comment 1 Armin Kuster 2019-12-19 15:36:16 UTC
Are you will to send a patch?
Comment 2 anon2313 2019-12-19 18:02:24 UTC
I can attach what I changed, but I'm not sure how this should be formatted or where to send it to.
Comment 3 anon2313 2019-12-19 18:03:23 UTC
Created attachment 4606 [details]
type fixed in Yocto patch
Comment 5 akuster 2020-05-28 08:09:51 UTC
patch sent.

https://patchwork.openembedded.org/patch/172933/
Comment 7 akuster 2020-06-04 07:14:29 UTC
closing