Bug 14948

Summary: create-spdx.bbclass: SPDX_INCLUDE_PACKAGED defined but not used
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Michael Opdenacker <michael.opdenacker>
Component: coreAssignee: Joshua Watt <JPEWhacker>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: Medium CC: meta.mr.watcher, meta.watcher, randy.macleod
Version: 4.1   
Target Milestone: 4.2   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: Yes (doc changes required)

Description Michael Opdenacker 2022-10-25 14:55:27 UTC
In meta/classes/create-spdx.bbclass, the SPDX_INCLUDE_PACKAGED variable is read into the "include_packaged" variable, which doesn't appear anywhere else.

As a consequence, this variable has no effect.

This could be a bug, this variable corresponding to functionality that is supposed to be implemented.

Otherwise, let's just remove the unnecessary dead code.
Comment 1 Michael Opdenacker 2022-10-25 15:03:38 UTC
Doc changes will be necessary if the code is fixed and eventually does something.
Comment 2 Michael Opdenacker 2022-10-31 08:29:38 UTC
Bug now closed thanks to https://git.openembedded.org/openembedded-core/commit/?id=89f1abd5e00807cf179ddf658f74d48119523b0c
No doc changes as this didn't get documented.