Bug 14948 - create-spdx.bbclass: SPDX_INCLUDE_PACKAGED defined but not used
Summary: create-spdx.bbclass: SPDX_INCLUDE_PACKAGED defined but not used
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 4.1
Hardware: x86 Multiple
: Medium minor
Target Milestone: 4.2
Assignee: Joshua Watt
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2022-10-25 14:55 UTC by Michael Opdenacker
Modified: 2022-10-31 08:29 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Yes (doc changes required)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Opdenacker 2022-10-25 14:55:27 UTC 
In meta/classes/create-spdx.bbclass, the SPDX_INCLUDE_PACKAGED variable is read into the "include_packaged" variable, which doesn't appear anywhere else.

As a consequence, this variable has no effect.

This could be a bug, this variable corresponding to functionality that is supposed to be implemented.

Otherwise, let's just remove the unnecessary dead code.
Comment 1 Michael Opdenacker 2022-10-25 15:03:38 UTC 
Doc changes will be necessary if the code is fixed and eventually does something.
Comment 2 Michael Opdenacker 2022-10-31 08:29:38 UTC 
Bug now closed thanks to https://git.openembedded.org/openembedded-core/commit/?id=89f1abd5e00807cf179ddf658f74d48119523b0c
No doc changes as this didn't get documented.