Bug 15222

Summary:	devtool upgrade ignores git system configuration
Product:	[Build System, Metadata & Runtime] OE-Core	Reporter:	Marcus Flyckt <marcus.flyckt>
Component:	Scripts and Tools	Assignee:	Marcus Flyckt <marcus.flyckt>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Medium	CC:	randy.macleod, ross.burton
Version:	4.0
Target Milestone:	5.0
Hardware:	x86
OS:	Multiple
Whiteboard:
OS type for building Yocto:	---	Type of Regression:	---
Verified:		Documentation change:	No (bug/feature does not impact docs)

Description Marcus Flyckt 2023-10-04 06:36:19 UTC

In my yocto docker container I have my git configuration at /etc/gitconfig (i.e `git config --system`). But `devtool upgrade` only checks `git --global` (i.e `$HOME/.gitconfig`) and complains that my git configuration is incomplete

```
pokyuser@c68fe28b8f36:/platform_builddir/build$ git config user.name
Marcus Flyckt
pokyuser@c68fe28b8f36:/platform_builddir/build$ git config user.email
mafl@kvaser.com
pokyuser@c68fe28b8f36:/platform_builddir/build$ devtool upgrade libdatachannel
NOTE: Starting bitbake server...
ERROR: Your git configuration is incomplete which will prevent rebases from working:
Please set your name using:
  git config --global user.name
Please set your email using:
  git config --global user.email
```

Comment 1 Ross Burton 2023-10-04 11:20:26 UTC

Sounds like an easy fix, can you send a patch?

Comment 2 Marcus Flyckt 2023-10-04 12:39:54 UTC

Sure. Where should I send that patch and in what format?

Comment 3 Ross Burton 2023-10-04 19:10:49 UTC

This will be an interesting test of the new Contributor Guide!

The actual code fix is, as far as I can tell, simply deleting "--global" from the correct git call.

Then follow the process documented in https://docs.yoctoproject.org/contributor-guide/submit-changes.html.  Please do say if there's anything missing or confusing in there, it's brand-new hot-off-the-press documentation that may well need tweaking.

Comment 4 Marcus Flyckt 2023-10-06 06:36:36 UTC

I've followed the documented process and submitted a patch to the Openembedded-core@lists.openembedded.org mailing list.

Comment 5 Ross Burton 2023-10-30 15:17:32 UTC

Fixed in 30a9f7de45050c8bac49d4b37419cc2e067a75fa.

Marcus, did you find any problems or gaps in the documentation?

Comment 6 Marcus Flyckt 2023-10-31 05:58:12 UTC

I followed the steps in the documentation verbatim. I found it comprehensive and simple to follow.