In my yocto docker container I have my git configuration at /etc/gitconfig (i.e `git config --system`). But `devtool upgrade` only checks `git --global` (i.e `$HOME/.gitconfig`) and complains that my git configuration is incomplete ``` pokyuser@c68fe28b8f36:/platform_builddir/build$ git config user.name Marcus Flyckt pokyuser@c68fe28b8f36:/platform_builddir/build$ git config user.email mafl@kvaser.com pokyuser@c68fe28b8f36:/platform_builddir/build$ devtool upgrade libdatachannel NOTE: Starting bitbake server... ERROR: Your git configuration is incomplete which will prevent rebases from working: Please set your name using: git config --global user.name Please set your email using: git config --global user.email ```
Sounds like an easy fix, can you send a patch?
Sure. Where should I send that patch and in what format?
This will be an interesting test of the new Contributor Guide! The actual code fix is, as far as I can tell, simply deleting "--global" from the correct git call. Then follow the process documented in https://docs.yoctoproject.org/contributor-guide/submit-changes.html. Please do say if there's anything missing or confusing in there, it's brand-new hot-off-the-press documentation that may well need tweaking.
I've followed the documented process and submitted a patch to the Openembedded-core@lists.openembedded.org mailing list.
Fixed in 30a9f7de45050c8bac49d4b37419cc2e067a75fa. Marcus, did you find any problems or gaps in the documentation?
I followed the steps in the documentation verbatim. I found it comprehensive and simple to follow.