| Summary: | Make patchtest check for use of deprecated CVE_CHECK_IGNORE | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Yocto Project Subprojects] Patchwork/Patchtest | Reporter: | Trevor Gamblin <tgamblin> | ||||
| Component: | Patchtest | Assignee: | Simone Weiß <simone.p.weiss> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | Medium+ | CC: | randy.macleod, simone.p.weiss | ||||
| Version: | 5.0 | ||||||
| Target Milestone: | 5.0 M2 | ||||||
| Hardware: | x86 | ||||||
| OS: | Multiple | ||||||
| Whiteboard: | |||||||
| OS type for building Yocto: | --- | Type of Regression: | --- | ||||
| Verified: | Documentation change: | Don't know | |||||
| Attachments: |
|
||||||
|
Description
Trevor Gamblin
2023-12-07 17:13:56 UTC
I would like to do this. I just assigned the issue now to myself. Hope that is fine. That's great. Let me know if you have issues. Created attachment 4999 [details]
patch including bb renamed vars
Hi Trevor, thanks for the offer. I have indeed some questions/issues now. After the first patch for this topic, it was suggested to also include checks for renamed variables. I have tried to implement such a check now, see also the attached patch above. While the check is fine and works, I wonder about how to handle subsequent tests, i.e. tests that are not pretests. When a patch containing a variable from BB_RENAMED_VARIABLES is already merged, the tinfoil setup while raise an error during parsing. This happens due to the check for such variables in lib/bb/data_smart.py and/or lib/bb/cookerdata.py. There a check for the usage of renamed variables is already performed before the testcase would run. Any suggestions how to handle this? Thanks Hmm, that is a problem. Generally speaking, patchtest shouldn't be testing things that the rest of the build system is already going to check. I know I agreed with the suggestion that it also look for those variables before, but given that it's causing a problem I think it'd be better to just take the patch you've already sent, and open a new bug for patchtest describing the need (i.e. to also check for BB_RENAMED_VARIABLES) and what's blocking it. |