Bug 15311 - Make patchtest check for use of deprecated CVE_CHECK_IGNORE
Summary: Make patchtest check for use of deprecated CVE_CHECK_IGNORE
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchtest (show other bugs)
Version: 5.0
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 5.0 M2
Assignee: Simone Weiß
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2023-12-07 17:13 UTC by Trevor Gamblin
Modified: 2024-01-10 15:19 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Don't know

Attachments
patch including bb renamed vars (3.33 KB, patch)
2023-12-17 18:38 UTC, Simone Weiß 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Trevor Gamblin 2023-12-07 17:13:56 UTC 
Patchtest should recommend the use of CVE_STATUS instead if CVE_CHECK_IGNORE is found.
Comment 1 Simone Weiß 2023-12-09 20:33:59 UTC 
I would like to do this. I just assigned the issue now to myself. Hope that is fine.
Comment 2 Trevor Gamblin 2023-12-11 17:22:08 UTC 
That's great. Let me know if you have issues.
Comment 3 Simone Weiß 2023-12-17 18:38:54 UTC 
Created attachment 4999 [details]
patch including bb renamed vars
Comment 4 Simone Weiß 2023-12-17 18:50:08 UTC 
Hi Trevor,

thanks for the offer. I have indeed some questions/issues now.

After the first patch for this topic, it was suggested to also include
checks for renamed variables. I have tried to implement such a check now, see also
the attached patch above.

While the check is fine and works, I wonder about how to
handle subsequent tests, i.e. tests that are not pretests. When a patch containing a
variable from BB_RENAMED_VARIABLES is already merged, the tinfoil setup while raise an
error during parsing. This happens due to the check for such variables in lib/bb/data_smart.py and/or lib/bb/cookerdata.py. There a check for the usage of renamed variables is already performed before the testcase would run. Any suggestions how to handle this?

Thanks
Comment 5 Trevor Gamblin 2023-12-18 18:42:03 UTC 
Hmm, that is a problem. Generally speaking, patchtest shouldn't be testing things that the rest of the build system is already going to check. I know I agreed with the suggestion that it also look for those variables before, but given that it's causing a problem I think it'd be better to just take the patch you've already sent, and open a new bug for patchtest describing the need (i.e. to also check for BB_RENAMED_VARIABLES) and what's blocking it.