| Summary: | scripts/send-pull-request cc:ing everyone mentioned in a resubmitted patch | ||
|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Meta-yocto | Reporter: | Tom Zanussi <tom.zanussi> |
| Component: | meta-yocto | Assignee: | Darren Hart <dvhart> |
| Status: | VERIFIED NOTABUG | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium | CC: | jessica.zhang, laurentiu.serban, poky.bs.watcher, poky.watcher |
| Version: | unspecified | ||
| Target Milestone: | 1.3 M3 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | --- | |
|
Description
Tom Zanussi
2012-07-11 06:04:04 UTC
Which command did you use to send the patches? Did you use -a or -c? -a OK, so this is working as documented in the help text:
-a Send the cover letter to every recipient listed in Cc and
Signed-off-by lines found in the cover letter and the patches.
This option implies -c.
At first I thought this was a repeat of the previous issue where patches being added to a recipe were being parsed and the CCs added - but it doesn't appear to be. The patch itself had these CC lines, so this is working as designed.
What behavior did you expect from -a?
Ah, ok, yeah, my mistake, I've just become used to always using -a without thinking about it or reading the help text. Basically send-pull-request should just never be used for linux-yocto kernel patches, period. Now I remember why I used to just do them manually... (In reply to comment #4) > Ah, ok, yeah, my mistake, I've just become used to always using -a without > thinking about it or reading the help text. > > Basically send-pull-request should just never be used for linux-yocto kernel > patches, period. > > Now I remember why I used to just do them manually... If you don't use -a -c then it will do the right thing and only send to the list specified via the -t on the command line. This is how I do it. Note that git send-email will embarass you in exactly the same way if using a similar option. setting this to verified |