Bug 2735 - scripts/send-pull-request cc:ing everyone mentioned in a resubmitted patch
Summary: scripts/send-pull-request cc:ing everyone mentioned in a resubmitted patch
Status: VERIFIED NOTABUG
Alias: None
Product: Meta-yocto
Classification: Build System, Metadata & Runtime
Component: meta-yocto (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.3 M3
Assignee: Darren Hart
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2012-07-11 06:04 UTC by Tom Zanussi
Modified: 2012-08-13 20:53 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Zanussi 2012-07-11 06:04:04 UTC
I just submitted a linux-yocto-3.0 kernel patchset to linux-yocto and was very unpleasantly surprised to see that the kernel devs mentioned in a resubmitted patch were automatically CC:ed on my Yocto e-mail cover letter as well as for the resubmitted patch:

https://lists.yoctoproject.org/pipermail/yocto/2012-July/010060.html
Comment 1 Darren Hart 2012-07-16 18:53:08 UTC
Which command did you use to send the patches? Did you use -a or -c?
Comment 2 Tom Zanussi 2012-07-16 18:58:05 UTC
-a
Comment 3 Darren Hart 2012-07-16 21:14:37 UTC
OK, so this is working as documented in the help text:

  -a           Send the cover letter to every recipient listed in Cc and
               Signed-off-by lines found in the cover letter and the patches.
	       This option implies -c.

At first I thought this was a repeat of the previous issue where patches being added to a recipe were being parsed and the CCs added - but it doesn't appear to be. The patch itself had these CC lines, so this is working as designed.

What behavior did you expect from -a?
Comment 4 Tom Zanussi 2012-07-16 21:34:51 UTC
Ah, ok, yeah, my mistake, I've just become used to always using -a without thinking about it or reading the help text.

Basically send-pull-request should just never be used for linux-yocto kernel patches, period.

Now I remember why I used to just do them manually...
Comment 5 Darren Hart 2012-07-16 21:57:01 UTC
(In reply to comment #4)
> Ah, ok, yeah, my mistake, I've just become used to always using -a without
> thinking about it or reading the help text.
> 
> Basically send-pull-request should just never be used for linux-yocto kernel
> patches, period.
> 
> Now I remember why I used to just do them manually...

If you don't use -a -c then it will do the right thing and only send to the list specified via the -t on the command line. This is how I do it. Note that git send-email will embarass you in exactly the same way if using a similar option.
Comment 6 Laurentiu Serban 2012-08-13 20:53:41 UTC
setting this to verified