Bug 3851

Summary: Hob intermediate state not saved when errors occur - Step 3 image creation
Product: [Build System, Metadata & Runtime] Hob Reporter: John "Warthog9" Hawley <yoctoproject>
Component: hobAssignee: Cristiana Voicu <cristiana.voicu>
Status: VERIFIED NOTABUG QA Contact:
Severity: normal    
Priority: Medium CC: andreea.b.proca, belen.barros.pena, corneliux.stoicescu, cristian.iorga, elizabeth.flanagan, jessica.zhang, poky.bs.watcher, poky.watcher, valentin.popa
Version: unspecified   
Target Milestone: 1.4 M5   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: ---
Attachments:
Description Flags
build-fail-flow.pdf none

Description John "Warthog9" Hawley 2013-02-06 09:41:57 UTC 
Hob has 3 main screens:

1) Image configuration

2) Selection of what to build

3) What to include in the images

In stage 3, the image building process, when errors occur the image creation process is stopped, and the screen the user is pushed to is the 1st screen, forcing the user to completely start over from scratch and do the entirety of the build process again, hopefully after they have figured out and completely resolved the problem.

================
Expected result:
================

The expected interaction would be that Hob would do some sort of temporary state saving, including what packages have been selected for inclusion in the image, before attempting to build the image.  Should there be errors, instead of kicking the user all the way back out to step 1, they should be brought back to the selection screen for step 3, along with the packages they had selected.  This gives the user the ability to potentially remove the offending package from the image build, or gives the user the ability to resolve the image creation issue and proceed without having to completely restart.

As an added advantage this and the state for step 2 (what packages to build) could conveniently be bundled allow for complete, reproducible builds, from within hob itself (not that this can't be done by building recipes and templates and such, but auto-building those from hob would make it slightly more user friendly)
Comment 1 Stoicescu Cornel 2013-02-13 12:16:33 UTC 
Hello,

Can you please add the following information:
-host operating system
-what environment did you use to run HOB? (poby build environment, build appliance)
-poky version (or branch + commit) - if you used the build appliance, the version of poky relevant for it

Note: you can also use the "Version" field.
Comment 2 Cristian Iorga 2013-02-18 07:33:37 UTC 
Hello Corneliu,

Thanks for helping out.
Can you please try to reproduce this issue on current version of poky repository?

Regards,
Cristian
Comment 3 Cristian Iorga 2013-02-18 07:34:18 UTC 
Please try to reproduce.
Comment 4 Stoicescu Cornel 2013-02-26 13:16:20 UTC 
Andreea, please test this :)
Comment 5 Cristiana Voicu 2013-03-04 08:19:54 UTC 
Hello,

There is nothing to test for this bug. The current implementation follows a design. Belen what do you think related to this approapch? Can you help me with this?

Cristiana
Comment 6 Belen Barros Pena 2013-03-04 10:39:07 UTC 
I've attached the relevant designs from bug 2183 (see build-fail-flow.pdf). If the build fails, the 'edit image' button should bring you to the previous step (recipes screen or packages screen depending on when the failure occurs). The document says that recipes and packages selections should be remembered. This is exactly what is described in the "Expected results" section of this bug (as far as I can see). 

I believe the button label 'edit image' might have changed, but the behaviour should be exactly the same, and I am pretty sure it was behaving as designed when I verified bug 2183.

If it's no longer working like this, we have a bug.

I hope this helps.

Belen


(In reply to comment #5)
> Hello,
> 
> There is nothing to test for this bug. The current implementation follows a
> design. Belen what do you think related to this approapch? Can you help me
> with this?
> 
> Cristiana
Comment 7 Belen Barros Pena 2013-03-04 10:39:36 UTC 
Created attachment 1103 [details]
build-fail-flow.pdf
Comment 8 Cristiana Voicu 2013-03-04 10:46:01 UTC 
Andreea, can you please test it to see if it is working as designed? If it is working as design, I think we should close this bug.

Thanks,
Cristiana
Comment 9 Andreea Brandusa Proca 2013-03-04 12:16:10 UTC 
Ok, I will test it :)
Comment 10 Andreea Brandusa Proca 2013-03-07 13:30:02 UTC 
I have tested it and the current implementation follows the design described by Belen in the document attached (the recipes and packages selected are remembered when the build fails).
Verified in master:d823759b4594143d522eae0b2a2498436a6dcb1e.
Comment 11 Andreea Brandusa Proca 2013-03-13 10:28:16 UTC 
I set it to not a bug.
Comment 12 Andreea Brandusa Proca 2013-03-18 08:47:16 UTC 
Verified.