The build failure scenario hasn't been implemented as for the document https://wiki.yoctoproject.org/wiki/File:Build-fail-flow-v1.0.pdf (I filed this bug as an enhancement because this process is still to be reviewed by the development team)
Hi Giulia, this function has be merged to poky/master, please to review.http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=374ad22550f0610f41e127352a3efb2c62689ff0
Created attachment 546 [details] build-failed.png build-failed.png shows what I see when the build fails. Not good :(
Hi Belen I can't see your attachment, please to attached again. and it your means the bug is not ok? what points about your concern
Hi Liming, It's a completely blank window. I've attached it again in a different format (build-failed.jpg). Let me know if you still can't see it. (In reply to comment #3) > Hi Belen I can't see your attachment, please to attached again. and it your > means the bug is not ok? what points about your concern
Created attachment 585 [details] build-failed.jpg
yes, it's a completely blank window, you want to changed to this window, if building failed? can you give me some description.
Hi Benlen, can you describe it clearly to how to fixed it. Thanks!
Will do. (In reply to comment #7) > Hi Benlen, can you describe it clearly to how to fixed it. Thanks!
Any update from Belen? It is also a blank window.
You mean I am a blank window??? ;) I have some work to do on 2345, 2162 and finishing up 2165. Once those are done I'll be able to tackle this one. Sorry for the delay: I am just a bit over-stretched right now. Cheers Belen
I know, Thanks!
(In reply to comment #10) > You mean I am a blank window??? ;) I have some work to do on 2345, 2162 and > finishing up 2165. Once those are done I'll be able to tackle this one. > Sorry for the delay: I am just a bit over-stretched right now. Cheers Belen I tried google translation to see any special meaning for "I am a blank window", but didn't have any findings:-) I didn't intend to offend you. Please let me know to avoid any misunderstanding in the future. Thanks.
Created attachment 634 [details] build-fail-spec.pdf I've attached a design document showing what happens when a build fails. Please note that this design depends on the implementation of bugs 1991 and 2165. Any questions, feedback, etc, let me know. Belen
Hi Belen, I know, I will refer to 1991 and 2165 to fixed this bug.Thanks!
Created attachment 636 [details] build-fail-spec.pdf
Changed as new ui design, please to review http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=limx/hob-bug-fixes-continue&id=a218bf8a38dfdd61421893ee2ae36c0bb91b55b8
Hi Liming, I've checked your branch. I have a couple of comments: 1. The label of the primary button should always be 'Edit image'. Right now, if you build without customisation, the button says: "Edit image configuration". If you build with customisation and package building fails, it says: "Edit recipes" 2. When you build with customisation and package building fails, the heading of the fail message should say: "Hob cannot build the packages". Right now it says: "Hob cannot build your recipes". 3. When the failure happens, the selected tab should be 'Issues'. Right now, the selected tab is 'Log' Thanks! Belen (In reply to comment #16) > Changed as new ui design, please to review > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=limx/hob- > bug-fixes-continue&id=a218bf8a38dfdd61421893ee2ae36c0bb91b55b8
Hi Belen, thanks your replay, I had changed it, please to reviewhttp://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=limx/hob-bug-fixes-continue
Hi Liming, This is looking good now. Thanks! Once your patch is merged to master, I'll check it there and mark it as verified. Belen
Created attachment 709 [details] wrong-number-of-issues.png Sorry, Liming, I forgot to mention that I am not sure the number of issues displayed is accurate. In the screenshot attached (wrong-number-of-issues.png) the tab announces 6 issues, but there are only 3 packages listed (zlib-native, gmp-native and pigz-native). How are we calculating the number of issues? Thanks! Belen
Hi Belen, the number of issues is same as the times of error occurs in the log page, so you can see there has two indicators or more in one recipe item which be built. because original design maybe mentioned the warning and error in issue category of 'issues', but now we only care of the error. Thanks!
Thanks! (In reply to comment #21) > Hi Belen, the number of issues is same as the times of error occurs in the > log page, so you can see there has two indicators or more in one recipe item > which be built. because original design maybe mentioned the warning and > error in issue category of 'issues', but now we only care of the error. > Thanks!
Hi Liming, Do you know if your patch has been merged to master? Thanks!
After some conversations with Cristiana when she was doing work on https://bugzilla.yoctoproject.org/show_bug.cgi?id=2537, we decided that button labels should change depending on where the build is stopped, and that they should be consistent in the case of the build failing. Therefore, for the case of a failed build: 1. If the build fails when building an image without customisation, we use 'edit image' as the button label. The button brings you back to the Image configuration screen (no matter when the build failed) 2. If when customising the base image the build fails while building the packages, we use 'edit recipes' as the button label. The button brings you back to the recipes selection screen 3. If when customising the base image the build fails while building the image, we use 'edit packages' as the button label. The button brings you back to the packages selection screen This is how Hob is currently working, so marking as verified.