| Summary: | Specify ACPI SPI UID=0 | ||
|---|---|---|---|
| Product: | [Hardware Platforms] MinnowBoard MAX Firmware | Reporter: | Darren Hart <dvhart> |
| Component: | minnowmax-edk2 | Assignee: | Darren Hart <dvhart> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium | CC: | sjolley.yp.pm |
| Version: | unspecified | ||
| Target Milestone: | Production Release | ||
| Hardware: | MinnowBoard Max | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
For the MinnowMax firmware, this is the SPI1 device (there is no SPI0 device):
Device (SPI1)
{
Name (_ADR, Zero) // _ADR: Address
Name (_HID, "80860F0E") // _HID: Hardware ID
Name (_CID, "80860F0E") // _CID: Compatible ID
Can we add:
Name (_UID, "0") // Static bus number assignment
the issue should be fixed by MNW2_IFWI_X64_R_2014_07_02_1150_SecEnabled.bin drop. Darren, please test and verify it at your end. Fixed in 07-10 firmware image. . |
The SPI bus number changes in the OS depending on if we are using PCI or ACPI enumeration. Currently PCI=0 and ACPI=32766. This is due to ACPI being dynamically numbered as the firmware does not specify the UID for the ACPI SPI master device. Please update the ACPI table to specify a UID of 0 for the SPI device: Device (SPI0) { Name(_HID, "80860F0E") Name(_UID, "0") ... } This will allow us to use the same SPI test driver for ACPI and PCI enumeration. It will also avoid unnecessary confusion for our users, and reduce the support and documentation burden on us.