Bug 6470 - Specify ACPI SPI UID=0
Summary: Specify ACPI SPI UID=0
Status: VERIFIED FIXED
Alias: None
Product: MinnowBoard MAX Firmware
Classification: Hardware Platforms
Component: minnowmax-edk2 (show other bugs)
Version: unspecified
Hardware: MinnowBoard Max Multiple
: Medium normal
Target Milestone: Production Release
Assignee: Darren Hart
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2014-06-20 16:14 UTC by Darren Hart
Modified: 2014-07-10 23:21 UTC (History)
1 user (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darren Hart 2014-06-20 16:14:27 UTC 
The SPI bus number changes in the OS depending on if we are using PCI or ACPI enumeration. Currently PCI=0 and ACPI=32766. This is due to ACPI being dynamically numbered as the firmware does not specify the UID for the ACPI SPI master device.

Please update the ACPI table to specify a UID of 0 for the SPI device:

  Device (SPI0)
  {
  	Name(_HID, "80860F0E")
	Name(_UID, "0")
	...
  }

This will allow us to use the same SPI test driver for ACPI and PCI enumeration. It will also avoid unnecessary confusion for our users, and reduce the support and documentation burden on us.
Comment 1 Darren Hart 2014-06-20 16:47:06 UTC 
For the MinnowMax firmware, this is the SPI1 device (there is no SPI0 device):

        Device (SPI1)
        {
            Name (_ADR, Zero)  // _ADR: Address
            Name (_HID, "80860F0E")  // _HID: Hardware ID
            Name (_CID, "80860F0E")  // _CID: Compatible ID

Can we add:

            Name (_UID, "0")  // Static bus number assignment
Comment 2 He, Tim 2014-07-03 08:02:28 UTC 
the issue should be fixed by MNW2_IFWI_X64_R_2014_07_02_1150_SecEnabled.bin drop. Darren, please test and verify it at your end.
Comment 3 Darren Hart 2014-07-10 23:20:51 UTC 
Fixed in 07-10 firmware image.
Comment 4 Darren Hart 2014-07-10 23:21:34 UTC 
.