Bug 9036

Summary: bitbake-prserv should not force umask in daemon mode
Product: [Build System, Metadata & Runtime] BitBake Reporter: Diego Santa cruz <Diego.SantaCruz>
Component: bitbakeAssignee: Richard Purdie <richard.purdie>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium CC: poky.bs.watcher, poky.watcher
Version: 2.0.2   
Target Milestone: 2.1 M3   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Attachments:
Description Flags
Do not clear umask of the PR Service in daemon mode none

Description Diego Santa cruz 2016-02-02 13:47:15 UTC
Created attachment 2964 [details]
Do not clear umask of the PR Service in daemon mode

The current bitbake-prserv forces the umask to 0 when daemonizing.

I think his should not be done, as it will make all files be created with permissions 0777 (world writable!) by default.

For instance, the PID file (/tmp/PRServer_*.pid) is created with permissions 0777 on my system (CentOS 7.2.1511).

It would be better to leave the umask unchanged, so whoever is starting bitbake-preserv gets to choose the umask it wants to use.

The attached patch does exactly this.