Bug 9036 - bitbake-prserv should not force umask in daemon mode
Summary: bitbake-prserv should not force umask in daemon mode
Status: RESOLVED FIXED
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: 2.0.2
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.1 M3
Assignee: Richard Purdie
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-02-02 13:47 UTC by Diego Santa cruz
Modified: 2016-02-11 20:59 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Do not clear umask of the PR Service in daemon mode (1.09 KB, text/plain)
2016-02-02 13:47 UTC, Diego Santa cruz 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Santa cruz 2016-02-02 13:47:15 UTC 
Created attachment 2964 [details]
Do not clear umask of the PR Service in daemon mode

The current bitbake-prserv forces the umask to 0 when daemonizing.

I think his should not be done, as it will make all files be created with permissions 0777 (world writable!) by default.

For instance, the PID file (/tmp/PRServer_*.pid) is created with permissions 0777 on my system (CentOS 7.2.1511).

It would be better to leave the umask unchanged, so whoever is starting bitbake-preserv gets to choose the umask it wants to use.

The attached patch does exactly this.