Bug 9304

Summary:	Attempt to remove pexpect requirement from rpm signing
Product:	[Build System, Metadata & Runtime] OE-Core	Reporter:	Ross Burton <ross.burton>
Component:	core	Assignee:	Markus Lehtonen <markus.lehtonen>
Status:	VERIFIED FIXED	QA Contact:	Valentin Hangan <valentinx.hangan>
Severity:	normal
Priority:	Medium+	CC:	meta.mr.watcher, meta.watcher, valentinx.hangan
Version:	2.1
Target Milestone:	2.1 M4
Hardware:	All
OS:	Multiple
Whiteboard:
OS type for building Yocto:	---	Type of Regression:	---
Verified:		Documentation change:	No (bug/feature does not impact docs)

Description Ross Burton 2016-03-18 09:53:31 UTC

meta/lib/oe/gpg_sign.py uses pexpect to feed RPM the gpg passphrase.  As pexpect isn't a core module this is an undocumented external dependency.  We need to see if this can be removed.

Comment 1 Markus Lehtonen 2016-03-22 15:36:00 UTC

One attempt submitted as an RFC patch:
http://patchwork.openembedded.org/patch/118373/

Comment 2 Valentin Hangan 2016-05-04 10:07:03 UTC

Verfied on master with commit: f7b520878babbaa7527151f22c031ae160512753
Pexpect is removed from function sign_rpms (meta/lib/oe/gpg_sign.py).

Run test signing packages:
oe-selftest --run-tests-by id 1362
2016-05-04 12:10:47,242 - selftest - INFO - Running bitbake -e to get BBPATH
DEBUG: tc id missing for test_sstate_noop_samesigs
2016-05-04 12:10:49,031 - selftest - INFO - Checking that everything is in order before running the tests
2016-05-04 12:10:49,954 - selftest - INFO - Running bitbake -p
2016-05-04 12:11:12,875 - selftest - INFO - Loading tests from: oeqa.selftest.signing.Signing.test_signing_packages
2016-05-04 12:11:12,875 - selftest - INFO - Adding: "include selftest.inc" in local.conf
2016-05-04 12:11:12,875 - selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
2016-05-04 12:11:12 - test_signing_packages (oeqa.selftest.signing.Signing) ... ok

----------------------------------------------------------------------
Ran 1 test in 1483.475s

OK
2016-05-04 12:35:56,351 - selftest - INFO - Finished
2016-05-04 12:35:56,351 - selftest - INFO - Removing the include from local.conf
2016-05-04 12:35:56,351 - selftest - INFO - Removing the include from bblayers.conf

Close this bug as VERIFIED - FIXED