Bug 9304 - Attempt to remove pexpect requirement from rpm signing
Summary: Attempt to remove pexpect requirement from rpm signing
Status: VERIFIED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 2.1
Hardware: All Multiple
: Medium+ normal
Target Milestone: 2.1 M4
Assignee: Markus Lehtonen
QA Contact: Valentin Hangan
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-03-18 09:53 UTC by Ross Burton
Modified: 2016-05-04 10:07 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Burton 2016-03-18 09:53:31 UTC 
meta/lib/oe/gpg_sign.py uses pexpect to feed RPM the gpg passphrase.  As pexpect isn't a core module this is an undocumented external dependency.  We need to see if this can be removed.
Comment 1 Markus Lehtonen 2016-03-22 15:36:00 UTC 
One attempt submitted as an RFC patch:
http://patchwork.openembedded.org/patch/118373/
Comment 2 Valentin Hangan 2016-05-04 10:07:03 UTC 
Verfied on master with commit: f7b520878babbaa7527151f22c031ae160512753
Pexpect is removed from function sign_rpms (meta/lib/oe/gpg_sign.py).

Run test signing packages:
oe-selftest --run-tests-by id 1362
2016-05-04 12:10:47,242 - selftest - INFO - Running bitbake -e to get BBPATH
DEBUG: tc id missing for test_sstate_noop_samesigs
2016-05-04 12:10:49,031 - selftest - INFO - Checking that everything is in order before running the tests
2016-05-04 12:10:49,954 - selftest - INFO - Running bitbake -p
2016-05-04 12:11:12,875 - selftest - INFO - Loading tests from: oeqa.selftest.signing.Signing.test_signing_packages
2016-05-04 12:11:12,875 - selftest - INFO - Adding: "include selftest.inc" in local.conf
2016-05-04 12:11:12,875 - selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
2016-05-04 12:11:12 - test_signing_packages (oeqa.selftest.signing.Signing) ... ok

----------------------------------------------------------------------
Ran 1 test in 1483.475s

OK
2016-05-04 12:35:56,351 - selftest - INFO - Finished
2016-05-04 12:35:56,351 - selftest - INFO - Removing the include from local.conf
2016-05-04 12:35:56,351 - selftest - INFO - Removing the include from bblayers.conf

Close this bug as VERIFIED - FIXED