| Summary: | piglit needs to be updated to run newer tests | ||
|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] OE-Core | Reporter: | Jianxun Zhang <jianxun.zhang> |
| Component: | graphics | Assignee: | Jussi Kukkonen <jku> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium | CC: | alex.kanavin, jku, meta.mr.watcher, meta.watcher |
| Version: | 2.1 | ||
| Target Milestone: | 2.2 | ||
| Hardware: | x86 | ||
| OS: | x86_64 | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
|
Description
Jianxun Zhang
2016-03-30 16:40:59 UTC
Upgrading piglit is on my list as well. It requires adding python-six to oe-core (or otherwise handling the new dependency). Alex: I think I can take this one if you want. Some notes on other piglit improvements: * should allow compiling piglit without X11 (there's a bug about this one) * should enable GBM backend (this is mostly changing waffle PACKAGECONFIG and setting PIGLIT_PLATFORM=gbm environment variable) The latter might be interesting for the IGT use case as well (it should allow running on a non-graphical image which would be faster to build and would presumably have more reproducible results). Sure, please do. When you do the update, you can switch piglit over to python 3 at the same time. The dependencies (python3-numpy, python3-mako, python3-nose) are now all available in oe-core specifically for that purpose :) (In reply to comment #4) > When you do the update, you can switch piglit over to python 3 at the same > time. The dependencies (python3-numpy, python3-mako, python3-nose) are now > all available in oe-core specifically for that purpose :) Thanks a lot. I'll include this in the next upgrade patchset. Didn't quite get this done for my last patchset, should be next week... (In reply to comment #4) > When you do the update, you can switch piglit over to python 3 at the same > time. The dependencies (python3-numpy, python3-mako, python3-nose) are now > all available in oe-core specifically for that purpose :) Just to make sure: It looks like I still have to move python3-six to oe-core for current piglit versions: I assume you checked the older versions dependencies? It's totally ok, just wanted to check that you didn't have some clever way to avoid the dependency... (In reply to comment #6) > Just to make sure: It looks like I still have to move python3-six to oe-core > for current piglit versions: I assume you checked the older versions > dependencies? > > It's totally ok, just wanted to check that you didn't have some clever way > to avoid the dependency... Yeah, I was working from the piglit recipe that is in oe-core now; I didn't check if the current piglit adds or removes or makes optional any of its dependencies. My 1 day estimate was a gross understatement even by software development estimation standards, but the patches are now on list. Some notes: * piglit by default fails 12000 tests, but this goes away when run without a window (e.g. with PIGLIT_NO_WINDOW=1). I suspect this is a test problem, discussing with upstream * piglit is now massive, 1.5G installed. It's pretty fast at runtime so the bottle neck at the moment is packaging. It takes forever. * I plan to enable gbm (instead of glx-egl) platform by default but decided to send this now (in case IGT is blocked by this). Jussi, thanks for your work on this issue! I should update IGT in meta-intel for the latest graphic stack release. Once I get a hand on it, will try to run test from new piglit. commit c3753a8b187c24fcac57c37c8a6d98be64af9f3b Author: Jussi Kukkonen <jussi.kukkonen@intel.com> Date: Wed Jul 13 20:00:33 2016 +0300 piglit: Upgrade version, use python3 * Remove backported patch * Update dependencies to use python3 modules, add depencies added in the new version * Install only stripped binaries to keep size down * Fix bash-completion install location (From OE-Core rev: f7193a306cfc3ac0a3fdcf891716a59f5b8178e8) Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> |