| Summary: | patchtest-oe: check that attached SW patches does not contain trailing spaces | ||
|---|---|---|---|
| Product: | [Yocto Project Subprojects] Patchwork/Patchtest | Reporter: | Leonardo Sandoval Gonzalez <leonardo.sandoval.gonzalez> |
| Component: | Patchtest | Assignee: | Jose Perez C <jose.perez.carranza> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | Medium+ | CC: | bluelightning, richard.purdie |
| Version: | 2.1 | ||
| Target Milestone: | 2.2 M2 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
|
Description
Leonardo Sandoval Gonzalez
2016-07-04 16:47:47 UTC
I feel this goes a bit too far. The benefit of validating this is going to be negligible. (In reply to comment #1) > I feel this goes a bit too far. The benefit of validating this is going to > be negligible. I understand your point; but why should git track blanks? The check is already implemented but for the moment is the todo folder. We may remove it later. The point is if we're going to be rejecting people's patches we should be doing so for good reasons. I just don't think this one qualifies. (In reply to comment #3) > The point is if we're going to be rejecting people's patches we should be > doing so for good reasons. I just don't think this one qualifies. I am following the first recommendation of this link: https://www.python.org/dev/peps/pep-0008/#other-recommendations As I said, right now the test does not hurt anyone, it is on the 'todo' checks. I can remove it anytime. Patch already sent to Leonardo Sandoval Gonzalez |