Bug 9876 - patchtest-oe: check that attached SW patches does not contain trailing spaces
Summary: patchtest-oe: check that attached SW patches does not contain trailing spaces
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchtest (show other bugs)
Version: 2.1
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 2.2 M2
Assignee: Jose Perez C
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-07-04 16:47 UTC by Leonardo Sandoval Gonzalez
Modified: 2017-12-06 16:57 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leonardo Sandoval Gonzalez 2016-07-04 16:47:47 UTC 
trailing spaces should not be present on sw patches, so do a check on these patches and fail if any of them has one or more.
Comment 1 Paul Eggleton 2016-07-06 02:15:19 UTC 
I feel this goes a bit too far. The benefit of validating this is going to be negligible.
Comment 2 Leonardo Sandoval Gonzalez 2016-07-06 13:49:37 UTC 
(In reply to comment #1)
> I feel this goes a bit too far. The benefit of validating this is going to
> be negligible.

I understand your point; but why should git track blanks? The check is already implemented but for the moment is the todo folder. We may remove it later.
Comment 3 Paul Eggleton 2016-07-06 20:03:48 UTC 
The point is if we're going to be rejecting people's patches we should be doing so for good reasons. I just don't think this one qualifies.
Comment 4 Leonardo Sandoval Gonzalez 2016-07-06 20:32:52 UTC 
(In reply to comment #3)
> The point is if we're going to be rejecting people's patches we should be
> doing so for good reasons. I just don't think this one qualifies.

I am following the first recommendation of this link:

https://www.python.org/dev/peps/pep-0008/#other-recommendations

As I said, right now the test does not hurt anyone, it is on the 'todo' checks. I can remove it anytime.
Comment 5 Jose Perez C 2016-07-11 13:44:53 UTC 
Patch already sent to Leonardo Sandoval Gonzalez