Bug 9959

Summary: patchtest-oe: the check for 'signed-off-by' format is failing on unicode names
Product: [Yocto Project Subprojects] Patchwork/Patchtest Reporter: Leonardo Sandoval Gonzalez <leonardo.sandoval.gonzalez>
Component: PatchtestAssignee: Daniela Plascencia <daniela.plascencia>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: Medium+ CC: sgw
Version: 2.3   
Target Milestone: 2.2 M3   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description Leonardo Sandoval Gonzalez 2016-07-15 21:12:16 UTC 
Current parser (pyparsing) is not parsing correctly those signed-off-by patches that contain unicode chars (like Aníbal Limón), thus giving false positives:

> git pw mbox 337 | patchtest - --test-dir ~/repos/pt-oe/tests --no-apply --raw
----------------------------------------------------------------------
Ran 4 tests in 6.249s

OK
[["ID", "mbox.signed_off_by.test_signed_off_by.SignedOffBy.test_signed_off_by_format"], ["line", "Signed-off-by: An\u00edbal Lim\u00f3n <anibal.limon@linux.intel.com>"], ["column", 18]]
[["ID", "mbox.subject.test_subject.Subject.test_subject_length"], ["Subject", "utils/qemurunner.py: QemuRunner.start() add support for specify extra kernel cmdline"], ["Length", "Current length 84 Max length 80"]]

where .git/config contains

[patchwork "default"]
        url = http://patchwork.openembedded.org
        project = oe-core
Comment 1 Leonardo Sandoval Gonzalez 2016-08-31 14:58:56 UTC 
Instead of using pyparsing, standard (regular expression) python module can be used.
Comment 2 Daniela Plascencia 2016-09-08 14:01:10 UTC 
Using pyparsing regular expressions to fix this bug.