Bug 9959 - patchtest-oe: the check for 'signed-off-by' format is failing on unicode names
Summary: patchtest-oe: the check for 'signed-off-by' format is failing on unicode names
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchtest (show other bugs)
Version: 2.3
Hardware: x86 Multiple
: Medium+ major
Target Milestone: 2.2 M3
Assignee: Daniela Plascencia
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-07-15 21:12 UTC by Leonardo Sandoval Gonzalez
Modified: 2017-12-06 17:03 UTC (History)
1 user (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leonardo Sandoval Gonzalez 2016-07-15 21:12:16 UTC 
Current parser (pyparsing) is not parsing correctly those signed-off-by patches that contain unicode chars (like Aníbal Limón), thus giving false positives:

> git pw mbox 337 | patchtest - --test-dir ~/repos/pt-oe/tests --no-apply --raw
----------------------------------------------------------------------
Ran 4 tests in 6.249s

OK
[["ID", "mbox.signed_off_by.test_signed_off_by.SignedOffBy.test_signed_off_by_format"], ["line", "Signed-off-by: An\u00edbal Lim\u00f3n <anibal.limon@linux.intel.com>"], ["column", 18]]
[["ID", "mbox.subject.test_subject.Subject.test_subject_length"], ["Subject", "utils/qemurunner.py: QemuRunner.start() add support for specify extra kernel cmdline"], ["Length", "Current length 84 Max length 80"]]

where .git/config contains

[patchwork "default"]
        url = http://patchwork.openembedded.org
        project = oe-core
Comment 1 Leonardo Sandoval Gonzalez 2016-08-31 14:58:56 UTC 
Instead of using pyparsing, standard (regular expression) python module can be used.
Comment 2 Daniela Plascencia 2016-09-08 14:01:10 UTC 
Using pyparsing regular expressions to fix this bug.