Bug 10047 - Piglit isn't in images (removed from tools-testapps)
Summary: Piglit isn't in images (removed from tools-testapps)
Status: RESOLVED WONTFIX
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: graphics (show other bugs)
Version: 2.2
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.5 M4
Assignee: Ross Burton
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-07-28 14:00 UTC by Jose Perez C
Modified: 2018-04-10 06:40 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: Regression (Used to work)
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Perez C 2016-07-28 14:00:37 UTC
STATUS: IDLE
BUILD: 2.2_M2 : 36feb38045b7a2af86ece147fec54b0db3bf491f
ENVIRONMENT: qemu-x86
STEPS TO REPRODUCE: 
  
 Having installed the core-image-sato-sdk image, run Piglit 3D testing suite:
piglit run /usr/lib/piglit/tests/quick.tests results/quick (The tests need display so if you're running through ssh, make sure to export DISPLAY=:0.0)

After the tests are completed run piglit summary html summary/quick_sum results/quick
Check summary/quick_sum/index.html report in browser 



EXPECTED OUTCOME: 
  
Results should be 9160/9597 pass rate for sugarbay
Results should be 9257/9691 pass rate for nuc


ACTUAL OUTCOME: 

Piglit test suite is not available under /usr/lib
Comment 1 Ross Burton 2016-07-28 15:28:30 UTC
So the problem is that new piglit is so giant it means that images couldn't be built.

oe-core 9e227ecb3a994133cf9b85d6dd424afe85edfbaf removed piglit from tools-testapps.
Comment 2 Jussi Kukkonen 2016-09-07 13:09:56 UTC
The bulk of the tests is in two sets of generated tests that are tiny and highly repetitive. Running "tar cJf" on the 1.4GB directory creates a 14MB tarball!

If we do that as part of install, we'd then have to fix the scripts to be able to extract the tests and make sure the image has 1.4 GB free space. This of course would make the image files the same size as before (unless we support sparse images)


Other than that the two sets of generated tests (about 9000 tests each) are for:
 * glsl-4.20
 * arb_vertex_attrib_64bit
Majority of the tests are essentially same (but not actually 100% same) in these two sets, former are for glsl-4.20 and the latter for an extension of glsl-1.30.

It would probably be possible (but not necessarily easy) to modify piglit to run these tests from single source, that might save 500MB. That would still make piglit close to 1 GB installed size so I'm not convinced it's worth the complexity.
Comment 3 Jussi Kukkonen 2016-09-07 14:19:02 UTC
(In reply to comment #0)
>  Having installed the core-image-sato-sdk image, run Piglit 3D testing suite:
> piglit run /usr/lib/piglit/tests/quick.tests results/quick (The tests need
> display so if you're running through ssh, make sure to export DISPLAY=:0.0)

Just a note: current piglit also requires PIGLIT_NO_WINDOW=1 to get results that are representative.
Comment 4 Jussi Kukkonen 2016-10-13 14:16:40 UTC
I did a test with piglit packaging 
  http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=jku/piglit-compress-tests

Installing piglit + piglit-generated-tests-compressed makes the image about 1.7 GB smaller than doing the same on current master. Image build time and test runtime are comparable to current master.

Currently recipe generates also the non-compressed version of the tests, not doing that would probably cut several minutes off the build time.
Comment 5 Jussi Kukkonen 2016-10-13 14:18:25 UTC
(In reply to comment #4)
> Installing piglit + piglit-generated-tests-compressed makes the image about
> 1.7 GB smaller than doing the same on current master. Image build time and
> test runtime are comparable to current master.

.. and the downside of course is that this needs 1.6 GB of free space on /usr/lib/piglit/ at runtime
Comment 6 Ross Burton 2017-02-21 18:04:15 UTC
Moving to jku as he sent patches.
Comment 7 Jussi Kukkonen 2017-06-08 12:42:38 UTC
No progress, moving straight to M3 as next milestone is getting crowded for me.
Comment 8 Ross Burton 2018-04-10 06:40:18 UTC
Piglit is huge, getting huger, and that won't change.

We'll continue to ship piglit and use it for testing but its too big for testapps.