Bug 10151 - Custom image recipe download button incorrect disabled state applied
Summary: Custom image recipe download button incorrect disabled state applied
Status: RESOLVED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: 2.3
Hardware: x86 Multiple
: Low minor
Target Milestone: 2.3
Assignee: Michael Wood
QA Contact: Libertad
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-08-16 09:48 UTC by Michael Wood
Modified: 2016-12-07 16:58 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Wood 2016-08-16 09:48:40 UTC
Libertad 2016-07-19 22:34:43 UTC 

Tested in master branch commit 627d01997fcf6a0581d88047735769ffb2592b82

To reproduce:

1. Start Toaster.
2. Create a project.
3. Create a custom image for the project based on core-image-minimal.
4. Try to download the custom image (project > configuration > custom images > click download icon next to custom image file name).

If I follow exactly the steps above I dont get the download icon next to custom image file name. I then click on the custom image created in step 3 and it redirects to the  view of "toaster-custom-images) where it allows me to build or download recipe file. The "Download recipe file" looks gray and disabled but it still clicks and redirects to an error attached in attachment 3295 [details].


To be able to download the custom-image-recipe.bb file before build is done building the following steps are taken:

1. Start Toaster.
2. Create a project.
3. Create a custom image for the project based on core-image-minimal.
4. Start Build of the custom image in step 3
5. Try to download the custom image (project > configuration > custom images > click download icon next to custom image file name).

The bb download icon appeared on the table and when clicking on it, the download started. which of the two scenarios should I take into consideration to verify or reopen this issue?

-----

Belen Barros Pena 2016-07-20 08:55:42 UTC

From the Bootstrap 3 documentation (http://getbootstrap.com/css/#buttons):

"Link functionality caveat 

This class [.disabled] uses pointer-events: none to try to disable the link functionality of <a>s, but that CSS property is not yet standardized and isn't fully supported in Opera 18 and below, or in Internet Explorer 11. In addition, even in browsers that do support pointer-events: none, keyboard navigation remains unaffected, meaning that sighted keyboard users and users of assistive technologies will still be able to activate these links. So to be safe, use custom JavaScript to disable such links."

We are currently using the disabled attribute for that link: we would need to replace it with the .disabled class and add custom js as advised.
Comment 1 Ross Burton 2016-12-07 16:58:34 UTC
Merged in bitbake bc8401e78cea140349bded228d38f72f628b3980.