Bug 10276 - [krogoth] python3-modules is not installable
Summary: [krogoth] python3-modules is not installable
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: devtools / tool chain (show other bugs)
Version: 2.1.2
Hardware: x86 Multiple
: High normal
Target Milestone: 2.1.2
Assignee: Alejandro Hernandez
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-09-14 12:59 UTC by Will Newton
Modified: 2016-09-24 08:26 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
Patch to python3 manifest (6.69 KB, patch)
2016-09-14 13:35 UTC, Will Newton
no flags Details | Diff
Fix the script that generates the manifest, regenerate manifest +extra dep fixes (16.21 KB, patch)
2016-09-14 14:46 UTC, Dmytro Milinevskyi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Will Newton 2016-09-14 12:59:17 UTC
The python3-modules package cannot be installed. I believe this is caused by some missing dependencies added in this commit:

commit cefa06d9852df6bd39a7bfe8c4f2d2b2ce4226ce
Author: Fabio Berton <fabio.berton@ossystems.com.br>
Date:   Tue Aug 23 18:23:59 2016 -0300

    python-3.5-manifest: Add argparse module
    
    Adding argparse module from Python's standard library. This allow use
    argparse without installing all python-misc modules. For compatibility,
    add python3-argparse as RDEPENDS to python3-misc.
    
    (From OE-Core rev: 6acbda5ac9c4edbcabbe11227db1655fbc8d904c)
    
    Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
    Signed-off-by: Ross Burton <ross.burton@intel.com>
    (cherry picked from commit f2b96001e074d26f5eb8711c2217a695fb02de4c)
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

These are:

python3-enum
python3-selectors
python3-signal
Comment 1 Will Newton 2016-09-14 13:35:24 UTC
Created attachment 3414 [details]
Patch to python3 manifest
Comment 2 Dmytro Milinevskyi 2016-09-14 14:46:06 UTC
Created attachment 3415 [details]
Fix the script that generates the manifest, regenerate manifest +extra dep fixes

This suppose to be a complete patch(at least for installing and running asyncio).
Not fixing the manifest by hand but fixing the script that generates it.
Comment 3 Will Newton 2016-09-14 14:52:21 UTC
The original backported commit says it adds argparse not the other packages, so it seems a minimal change to only fix the script output (this is on a release branch after all). On the other hand either way of fixing it works for me.
Comment 4 Dmytro Milinevskyi 2016-09-14 15:48:58 UTC
Ok, I don't mind. Should I create another bug for master?
Comment 5 Will Newton 2016-09-19 08:55:39 UTC
I'm not sure if there is a similar problem on master. The issue I intended to report was on the krogoth (2.1) branch which has regressed since the above mentioned commit.

Applying the attached patch or re-running the manifest generation script should suffice to fix this particular issue.
Comment 6 Alejandro Hernandez 2016-09-21 21:05:12 UTC
While the bug does exists, the comments are very confusing, since you are stating that a patch to add python3-argparse somehow deleted dependencies on python3-selectors, python3-enum and python3-signal, I don't see how that happened tbh, and then on the patch to fix that, thos packages are actually taken away and not added to the script or the manifest.

On the other hand the other patch takes care of other different things.

I was able to reproduce the bug and produce a patch by refactoring 0cff756e15fe69be6e17bc46863f4b57a43e20a8 from master.
Comment 7 Alejandro Hernandez 2016-09-21 21:15:44 UTC
Patch sent, now in review.
Comment 8 Will Newton 2016-09-22 09:56:41 UTC
Sorry, I was a little unclear. The problematic patch added new dependencies (RDEPENDS), but those dependencies were then missing as the packages did not exist. Thanks for working on the fix!