Bug 10563 - devtool: traceback when trying to generate a patch
Summary: devtool: traceback when trying to generate a patch
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: devtools / tool chain (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.3 M1
Assignee: Paul Eggleton
QA Contact: Francisco Pedraza
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-11-01 09:29 UTC by Igor Stoppa
Modified: 2016-12-06 17:28 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Don't know


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Stoppa 2016-11-01 09:29:51 UTC
Pre-conditions:

I'm working on the recipe initramfs-framework, I want to modify 2 of the files shipped, so that I can produce a patch, to use in a separate layer, through a bbappend.

I'm using the mater from poky.


Steps to trigger the problem:


0) prepare the build directory

1) from the build directory execute:
   devtool modify initramfs-framework

2) modify the files in the copy of the recipe, which is replicated by devtool in:
   /home/igor/dev/poky/build/workspace/sources/initramfs-framework
   vim /home/igor/dev/poky/build/workspace/sources/initramfs-framework/oe-local-files/rootfs
   vim /home/igor/dev/poky/build/workspace/sources/initramfs-framework/oe-local-files/init

3) test the changes

4) try to generate the patch:
   devtool finish initramfs-framework meta 
     or
   devtool finish initramfs-framework meta-ostree


outcome:
  File "/home/igor/dev/poky/scripts/devtool", line 344, in <module>
    ret = main()
  File "/home/igor/dev/poky/scripts/devtool", line 331, in main
    ret = args.func(args, config, basepath, workspace)
  File "/home/igor/dev/poky/scripts/lib/devtool/standard.py", line 1537, in finish
    _update_recipe(args.recipename, workspace, rd, args.mode, appendlayerdir, wildcard_version=True, no_remove=False, initial_rev=args.initial_rev)
  File "/home/igor/dev/poky/scripts/lib/devtool/standard.py", line 1332, in _update_recipe
    updated = _update_recipe_patch(recipename, workspace, srctree, rd, appendlayerdir, wildcard_version, no_remove, initial_rev)
  File "/home/igor/dev/poky/scripts/lib/devtool/standard.py", line 1209, in _update_recipe_patch
    upd_f, new_f, del_f = _export_local_files(srctree, rd, local_files_dir)
  File "/home/igor/dev/poky/scripts/lib/devtool/standard.py", line 1029, in _export_local_files
    git_files = _git_ls_tree(srctree)
  File "/home/igor/dev/poky/scripts/lib/devtool/standard.py", line 334, in _git_ls_tree
    for line in out.split('\0'):
TypeError: 'str' does not support the buffer interface