Bug 10610 - meta-intel unconditionally overrides scripts/lib/wic/canned-wks/systemd-bootdisk.wks
Summary: meta-intel unconditionally overrides scripts/lib/wic/canned-wks/systemd-bootd...
Status: RESOLVED FIXED
Alias: None
Product: BSPs
Classification: Build System, Metadata & Runtime
Component: bsps-meta-intel (show other bugs)
Version: 2.2
Hardware: x86 Multiple
: High major
Target Milestone: 2.2 M4
Assignee: Saul Wold
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-11-07 19:53 UTC by Christopher Larson
Modified: 2016-11-10 15:49 UTC (History)
0 users

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Larson 2016-11-07 19:53:47 UTC
BSP layers should not be altering the build unless MACHINE is set. This is part of the Yocto Project compliance guidelines. If meta-intel wants to provide a custom .wks for its BSPs, it should be providing its own, not overriding a file from oe-core. The file in meta-intel removes the serial console from the kernel append regardless of what MACHINE I'm targeting, which isn't ideal. The addition of --use-uuid is less harmful, though still goes against our policies.