Bug 10625 - Don't show "Series without cover letter" for series without cover letter
Summary: Don't show "Series without cover letter" for series without cover letter
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchwork (show other bugs)
Version: unspecified
Hardware: All Multiple
: Medium+ enhancement
Target Milestone: 2.3 M1
Assignee: Jose Lamego
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-11-08 16:35 UTC by Ross Burton
Modified: 2017-12-06 17:15 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Burton 2016-11-08 16:35:07 UTC
If a series of patches is sent without a cover letter then it appears in the series list as "Series without cover letter", which is useless.

Showing something like the first patch summary then "(and X more)" would be a start.
Comment 1 Jose Lamego 2016-11-25 15:27:33 UTC
The change in [1] is under review. Once approved, it will be pushed to production.

[1] https://lists.yoctoproject.org/pipermail/yocto/2016-November/033207.html
Comment 2 Leonardo Sandoval Gonzalez 2016-11-25 16:07:04 UTC
(In reply to comment #1)
> The change in [1] is under review. Once approved, it will be pushed to
> production.
> 
> [1] https://lists.yoctoproject.org/pipermail/yocto/2016-November/033207.html

Jose, can you apply this patch on the staging repo so I can see some examples?

Another possible series shortlog is to show first n-targets from the series patches. By target I mean the first part of the shorlog before the colon.
Comment 3 Jose Lamego 2016-11-25 16:53:09 UTC
An example of a series sent without cover letter can be seen in 
https://patchwork-staging.openembedded.org/series/3850/

This is the rationale for the naming choice:
- Using the first 30 characters of first series patch's summary plus ellipsis (...) between double quotation marks clearly denotes that the string is a reference to a patch summary, not the current item's. The size limit deals with long summaries to maintain readability at the series list view.

Including all the patch targets in the summary could be problematic for large series, and given the fact that many series patches have a common target, it could end up confusing.
Comment 4 Jose Lamego 2016-11-30 17:22:23 UTC
A v2 patch was submitted in [1] to handle one-patch series without cover letter, where the "1/1" prefix caused that the series was named with the default string.

[1] https://lists.yoctoproject.org/pipermail/yocto/2016-November/033286.html
Comment 5 Jose Lamego 2016-12-09 17:14:22 UTC
A v4 patch was submitted in [3] to handle one-patch series sent without cover-letter. This patch is merged in the production repository, waiting for the patchwork to be pointed to the repository's HEAD.
Comment 6 Jose Lamego 2016-12-13 17:54:19 UTC
Fix is now implemented. An example of the new series naming is in:
https://patchwork.openembedded.org/series/4369/