Bug 10635 - matchbox-window-manager: _NET_CURRENT_DESKTOP is not implemented correctly
Summary: matchbox-window-manager: _NET_CURRENT_DESKTOP is not implemented correctly
Status: VERIFIED FIXED
Alias: None
Product: Matchbox
Classification: Yocto Project Subprojects
Component: matchbox (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.3 M1
Assignee: Jussi Kukkonen
QA Contact: Juan Ramos
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-11-09 14:34 UTC by Raphael Kubo da Costa (rakuco)
Modified: 2017-01-10 21:58 UTC (History)
1 user (show)

See Also:
OS type for building Yocto: ---
Type of Regression: New (Never tested)
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (rakuco) 2016-11-09 14:34:07 UTC 
matchbox-window-manager returns an empty value when one queries the _NET_CURRENT_DESKTOP X11 property.

This can be easily verified by adding xprop to a test image and calling "xprop -root _NET_CURRENT_DESKTOP" -- an empty value will be returned instead of a number.

http://git.yoctoproject.org/cgit/cgit.cgi/matchbox-window-manager/commit/?id=050b414cf6e1a24c0c2489257cdb4a9fd482afc9 introduced the bug by passing 0 to the wrong XChangeProperty() argument.

This causes a crash in Chromium debug builds, as there is a debug assertion expecting _NET_CURRENT_DESKTOP not to return an empty string.
Comment 1 Jussi Kukkonen 2016-12-14 12:18:16 UTC 
commit 1417adcf53336bd65799f116f19237092a60d9c8
Author: Jussi Kukkonen <jussi.kukkonen@intel.com>
Date:   Thu Dec 8 13:05:25 2016 +0200

    matchbox-wm: Upgrade 1.2.1 -> 1.2.2
    
    Fixes [YOCTO #10635]: _NET_CURRENT_DESKTOP returns empty value.
    
    (From OE-Core rev: f63c75cc0da4f64ed2d769690122a34d40f7af49)
Comment 2 Juan Ramos 2017-01-10 21:58:28 UTC 
(In reply to comment #1)
> commit 1417adcf53336bd65799f116f19237092a60d9c8
> Author: Jussi Kukkonen <jussi.kukkonen@intel.com>
> Date:   Thu Dec 8 13:05:25 2016 +0200
> 
>     matchbox-wm: Upgrade 1.2.1 -> 1.2.2
>     
>     Fixes [YOCTO #10635]: _NET_CURRENT_DESKTOP returns empty value.
>     
>     (From OE-Core rev: f63c75cc0da4f64ed2d769690122a34d40f7af49)

Tested in adb34b8ddcd8cc34ae7d2b1b2e4b4d291d790f56, with core-image-sato-sdk-genericx86-64.hddimg
downloaded from: http://autobuilder.yoctoproject.org/pub/releases/yocto-2.3_M1.rc1/machines/genericx86-64/

$xprop -root _NET_CURRENT_DESKTOP
_NET_CURRENT_DESKTOP(CARDINAL)= 0

Verified.