Bug 10650 - Import non-git layer directory path input validation is incorrect
Summary: Import non-git layer directory path input validation is incorrect
Status: RESOLVED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: 2.3
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.4 M4
Assignee: David Reyna
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-11-11 18:08 UTC by Michael Wood
Modified: 2017-12-06 17:16 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Wood 2016-11-11 18:08:27 UTC 
Steps to reproduce:
 - Try to import a non-git layer by entering a path that contains "."

Outcome
 - Error message "The directory path cannot include spaces or any of these characters: . \ ? % * : | " " < >"

This is not correct. At the very least you definitely can have a "." character if not others. You can also use the layer details page to fix this as the validation doesn't happen there which is inconsistent.
Comment 1 David Reyna 2016-11-16 06:13:46 UTC 
I a wondering if we need the quote characters in case someone has a space in the path name (which we all dislike but it happens, sometimes from above). In this case we either need the quotes or the backhash as the escape. 

The others I am happy to restrict.

Also, the download path code also has the same restriction around dots in the path. I think that this should be changed for that as well as layer paths.
Comment 2 David Reyna 2016-11-16 06:18:42 UTC 
Well ok, the Toaster code and documentation says no spaces, so I will stay with that.
Comment 3 David Reyna 2017-09-18 17:34:27 UTC 
commit ce57a391af3c4b7c9c91a65a82eb604a2665e910
(Bitbake rev: 9c0f6e81dae0b91b425e6c0cdf64caa5c15d92b5)