Bug 10679 - Drop unneeded expansion parameter to getVar and getVarFlag
Summary: Drop unneeded expansion parameter to getVar and getVarFlag
Status: RESOLVED FIXED
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: 2.3
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 2.3 M1
Assignee: Joshua Lock
QA Contact: David Lopez Barriba
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-11-16 13:02 UTC by Richard Purdie
Modified: 2017-01-17 14:03 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Yes (doc changes required)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Purdie 2016-11-16 13:02:06 UTC 
There are patches pending which make expansion the default for getVar/getVarFlag. Once merged we should remove the expansion parameter from most of the users of getVar and getVarFlag. There are sed expressions in the git history which can be used as a template to do this.
Comment 1 Robert Yang 2016-11-18 01:47:51 UTC 
Josh will work on it.
Comment 2 Joshua Lock 2016-11-22 22:32:35 UTC 
I have patches queued for this change using regex search/replace with the following regex:

getVar ?\(( ?[^,()]*), True\)
getVar($1)

getVarFlag ?\(( ?[^,()]*, ?[^,()]*), True\)
getVarFlag($1)