Bug 10718 - send-pull-request: Avoid creating duplicated email reference headers
Summary: send-pull-request: Avoid creating duplicated email reference headers
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: Scripts and Tools (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.3 M1
Assignee: Jose Lamego
QA Contact: Juan Ramos
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-11-23 21:53 UTC by Jose Lamego
Modified: 2016-12-14 21:23 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
Multiple header message example (53.99 KB, message/rfc822)
2016-11-23 21:53 UTC, Jose Lamego
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Lamego 2016-11-23 21:53:55 UTC
Created attachment 3546 [details]
Multiple header message example

When creating a patch set with cover letter using the send-pull-request script, both the "In-Reply-To" and "References" headers are appended twice, the first (from bottom to top of the headers) with the cover letter msgid, and the second with the patch #1's msgid.

Some tools such as patchwork use only the first found header (the one at the top of the headers) to create a references list, thus skipping a reference to the cover letter and causing corrupted revision numbering for new series.

The only existing reference should be pointing to the very first message in the series, i.e.: the cover letter when available.
Comment 1 Jose Lamego 2016-11-25 20:34:07 UTC
Fix was sent for review. It is available in:
http://lists.openembedded.org/pipermail/openembedded-core/2016-November/129276.html
Comment 2 Ross Burton 2016-12-07 16:53:33 UTC
Merged in oe-core 303a1aa3df43eb0b693d8602062fa33c4a08fdd6.
Comment 3 Ross Burton 2016-12-07 16:53:46 UTC
Merged in oe-core 303a1aa3df43eb0b693d8602062fa33c4a08fdd6.