Bug 10759 - patchwork: post-receive git hook is not functional
Summary: patchwork: post-receive git hook is not functional
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchwork (show other bugs)
Version: 2.3
Hardware: x86 Multiple
: Undecided normal
Target Milestone: 2.3 M1
Assignee: Jose Lamego
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-12-02 15:43 UTC by Jose Lamego
Modified: 2017-12-06 17:19 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Lamego 2016-12-02 15:43:39 UTC
The patchwork post-receive git hook automatically updates a patch status to Accepted when it gets pushed to master.
The hook stopped working apparently after enabling it for all projects, from previous configuration that only included oe-core.
Comment 1 Martin Jansa 2016-12-02 17:47:17 UTC
It never worked for meta-oe, it maybe marked one patch in 1000. Maybe it doesn't mark patches which are already in some bundle (all meta-oe patches go first to master-next bundle and then they are merged after testing in master-next branch/bundle).

So it probably isn't related to enabling it for all projects.
Comment 2 Jose Lamego 2016-12-02 18:02:56 UTC
Correct, this isn't related to the per-project configuration, but to the post-receive git hook having a hard-coded path to patchwork, which does not reflect the actual path in the production server. 

We just recently pointed the server to the Yocto-hosted repository [1], and may skipped to update that line.

Upon confirmation of that path, I will submit a patch to update the hook.

[1] git://git.yoctoproject.org/patchwork
Comment 3 Michael Halstead 2016-12-03 00:25:54 UTC
After removing

[options]
default=oe-core

from .pwclientrc pwclient exits with the following

ConfigParser.NoSectionError: No section: 'base'.

I've reverted the change and now oe-core is updating again.

What do we try next for the other projects?
Comment 4 Jose Lamego 2016-12-03 11:30:22 UTC
(In reply to comment #3)
> After removing
> 
> [options]
> default=oe-core
> 
> from .pwclientrc pwclient exits with the following
> 
> ConfigParser.NoSectionError: No section: 'base'.
> 
> I've reverted the change and now oe-core is updating again.
> 
> What do we try next for the other projects?

Thanks Michael. I'm closing this bug now and will track the all-projects enabling request separately.