Bug 10778 - Adopt skipStep() throughout the codebase
Summary: Adopt skipStep() throughout the codebase
Status: RESOLVED FIXED
Alias: None
Product: AutoBuilder
Classification: Infrastructure
Component: autobuilder (show other bugs)
Version: 2.2
Hardware: x86 Multiple
: Medium enhancement
Target Milestone: 2.3 M2
Assignee: Joshua Lock
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2016-12-08 15:25 UTC by Joshua Lock
Modified: 2016-12-21 17:04 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Lock 2016-12-08 15:25:36 UTC 
We introduced a method on the BitbakeShellCommand base class for unifying the way in which a buildstep is skipped, we should adopt this pattern throughout the codebase but shouldn't do so until after M1.
Comment 1 Joshua Lock 2016-12-20 15:13:48 UTC 
There are relatively few spots left where adopting using this method makes sense, but a patch has been written to do so.
Comment 2 Joshua Lock 2016-12-21 17:04:53 UTC 
skipStep() used everywhere it makes sense, most recently:

http://git.yoctoproject.org/clean/cgit.cgi/yocto-autobuilder/commit/?id=f70c7bf903ab62a7b2db540b2d33881166c383bd