Bug 11090 - linux-firmware-carl9170 doesn't set LICENSE
Summary: linux-firmware-carl9170 doesn't set LICENSE
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: kernel (show other bugs)
Version: 2.2
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.3 M4
Assignee: Ng, Wei Tee
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-02-21 00:57 UTC by Ross Burton
Modified: 2017-04-18 09:39 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Burton 2017-02-21 00:57:03 UTC 
A tool I am writing tells me that the license on the linux-firmware-carl9170 package is:

Firmware-Abilis     & Firmware-adsp_sst     & Firmware-agere     & Firmware-amdgpu     & Firmware-amd-ucode     & Firmware-atheros_firmware     & Firmware-atmel     & Firmware-broadcom_bcm43xx     & Firmware-ca0132     & Firmware-cavium     & Firmware-chelsio_firmware     & Firmware-cw1200     & Firmware-dib0700     & Firmware-e100     & Firmware-ene_firmware     & Firmware-fw_sst_0f28     & Firmware-go7007     & Firmware-hfi1_firmware     & Firmware-i2400m     & Firmware-i915     & Firmware-ibt_firmware     & Firmware-it913x     & Firmware-iwlwifi_firmware     & Firmware-IntcSST2     & Firmware-kaweth     & Firmware-Marvell     & Firmware-moxa     & Firmware-mwl8335     & Firmware-myri10ge_firmware     & Firmware-nvidia     & Firmware-OLPC     & Firmware-ath9k-htc     & Firmware-phanfw     & Firmware-qat     & Firmware-qla1280     & Firmware-qla2xxx     & Firmware-qualcommAthos_ar3k     & Firmware-qualcommAthos_ath10k     & Firmware-r8a779x_usb3     & Firmware-radeon     & Firmware-ralink_a_mediatek_company_firmware     & Firmware-ralink-firmware     & Firmware-rtlwifi_firmware     & Firmware-siano     & Firmware-tda7706-firmware     & Firmware-ti-connectivity     & Firmware-ti-keystone     & Firmware-ueagle-atm4-firmware     & Firmware-via_vt6656     & Firmware-wl1251     & Firmware-xc4000     & Firmware-xc5000     & Firmware-xc5000c     & WHENCE

That's the recipe license, not the license of the carl9170 firmware.
Comment 1 Ross Burton 2017-02-23 16:12:18 UTC 
Apparently this bug is too terse.

The recipe license on linux-firmware is the giant string above.  Each package sets its own license to reflect the license of the contents, apart from linux-firmware-carl9170.    As the license on the firmware isnt the same as the license for the entire source package, it should set the license explicitly.
Comment 2 Ng, Wei Tee 2017-04-05 06:50:50 UTC 
Input from Ross Burton:

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ is the upstream source that we download.  There's a carl9170-1.fw file which is the pre-compiled firmware, and a carl9170fw directory which contains the source (fimware with source! very unusual).  A license summary for linux-firmware is in the WHENCE:

Driver: carl9170 -- Atheros AR9170 802.11 draft-n USB driver
File: carl9170-1.fw
Version: 1.9.6
Source: carl9170fw/
Downloaded from http://linuxwireless.org/en/users/Drivers/carl9170
Licence: GPLv2. Some build scripts use t> he New BSD (3-clause) licence.. See GPL-2 for details.

(why they named it WHENCE is beyond me, it's like they're being to be difficult)

So, the license is GPLv2.  This can be confirmed by looking at carl9170fw/COPYRIGHT which also says GPLv2.
Comment 3 Ross Burton 2017-04-14 14:34:29 UTC 
That's not what waitforupstream is for.
Comment 4 Ross Burton 2017-04-18 09:39:07 UTC 
When closing a bug, please mention which commit it was resolved in.

Merged in oe-core a062b2aa51e28aa14e75435d8a618859499e1bd5.