Bug 11162 - yocto-compat-layer: filter out false positives (?)
Summary: yocto-compat-layer: filter out false positives (?)
Status: RESOLVED FIXED
Alias: None
Product: Meta-yocto
Classification: Build System, Metadata & Runtime
Component: meta-yocto (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.3 M4
Assignee: Aníbal Limón
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-03-15 10:13 UTC by Patrick Ohly
Modified: 2017-03-22 17:51 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Ohly 2017-03-15 10:13:39 UTC 
When analysing meta-intel, the signature check fails for packagegroup-core-lsb and meta-world-pkgdata. Is the change in meta-world-pkgdata really a problem in the layer? It might be due to additional recipes that become part of a world build, which may or may not be allowed for a BSP layer (not sure myself).

If it is allowed by "Yocto Compatibility 2.0", then the test tool needs to filter out that false positive.

Full output:

yocto-compat-layer.py -d /fast/work/meta-intel 
INFO: Detected layers:
INFO: meta-intel: LayerType.BSP, /fast/work/meta-intel
INFO: meta-tlk: LayerType.SOFTWARE, /fast/work/meta-intel/meta-tlk
INFO: 
INFO: Getting initial bitbake variables ...
INFO: Getting initial signatures ...
INFO: 
INFO: Starting to analyze: meta-intel
INFO: ----------------------------------------------------------------------
INFO: test_bsp_defines_machines (bsp.BSPCompatLayer) ... ok
INFO: test_bsp_no_set_machine (bsp.BSPCompatLayer) ... ok
INFO: test_parse (common.CommonCompatLayer) ... ok
INFO: test_readme (common.CommonCompatLayer) ... ok
INFO: test_show_environment (common.CommonCompatLayer) ... ok
INFO: test_signatures (common.CommonCompatLayer) ... FAIL
INFO: skipped "DistroCompatLayer: Layer meta-intel isn't Distro one."
INFO: 
INFO: ======================================================================
INFO: FAIL: test_signatures (common.CommonCompatLayer)
INFO: ----------------------------------------------------------------------
INFO: Traceback (most recent call last):
  File "/fast/work/poky/scripts/lib/compatlayer/cases/common.py", line 65, in test_signatures
    (self.tc.layer['name'], detail))
AssertionError: True is not false : Layer meta-intel changed signatures.
packagegroup-core-lsb:do_build changed c933b18e073bcc97dae110b856354424 -> 11deb486eea0428dd9b96640990e6606
packagegroup-core-lsb:do_package_write_rpm changed 1bc1a06f6d054e6b915f3a55b419c074 -> 927a946c9df49cd741194b4b5910ff99
packagegroup-core-lsb:do_packagedata changed 8f948711b648a53f2715542d45ed21be -> 7940f9361b3e46e2014738703bd88d08
packagegroup-core-lsb:do_package_qa changed 74390696ad32aec1c4a699aac0790874 -> 14e027d9d76866f5b628bbb37734321d
meta-world-pkgdata:do_build changed aeab5df30d098cbddf2b1599f463f005 -> 13f8803667d8e2e7d3779028521446fd
packagegroup-core-lsb:do_package changed a8a3700c3fb7d31e2a3db467c3fd598b -> d2b15a26df2358fef1c609cf172387c4
Comment 1 Aníbal Limón 2017-03-20 21:35:07 UTC 
I added a explicit exclude of meta-world-pkgdata in signature comparison,

http://lists.openembedded.org/pipermail/openembedded-core/2017-March/134382.html

Now the meta-intel layer passed, the other modifications in packagegroups seems related to other layer im working on #11164 to isolate the environment.
Comment 2 Aníbal Limón 2017-03-20 21:38:19 UTC 
(In reply to comment #1)
> I added a explicit exclude of meta-world-pkgdata in signature comparison,
> 
> http://lists.openembedded.org/pipermail/openembedded-core/2017-March/134382.
> html
> 
> Now the meta-intel layer passed, the other modifications in packagegroups
> seems related to other layer im working on #11164 to isolate the environment.

Log output,

INFO: Detected layers:
INFO: meta-intel: LayerType.BSP, ../meta-intel
INFO: meta-tlk: LayerType.SOFTWARE, ../meta-intel/meta-tlk
INFO:
INFO: Getting initial bitbake variables ...
INFO: Getting initial signatures ...
INFO:
INFO: Starting to analyze: meta-intel
INFO: ----------------------------------------------------------------------
INFO: test_bsp_defines_machines (bsp.BSPCompatLayer) ... ok
INFO: test_bsp_no_set_machine (bsp.BSPCompatLayer) ... ok
INFO: test_parse (common.CommonCompatLayer) ... ok
INFO: test_readme (common.CommonCompatLayer) ... ok
INFO: test_show_environment (common.CommonCompatLayer) ... ok
INFO: test_signatures (common.CommonCompatLayer) ... ok
INFO: skipped "DistroCompatLayer: Layer meta-intel isn't Distro one."
INFO:
INFO: ----------------------------------------------------------------------
INFO: Ran 6 tests in 34.412s
INFO:
INFO: OK (skipped=1)
INFO: Starting to analyze: meta-tlk
INFO: ----------------------------------------------------------------------
INFO: skipped "BSPCompatLayer: Layer meta-tlk isn't BSP one."
INFO: test_parse (common.CommonCompatLayer) ... ok
INFO: test_readme (common.CommonCompatLayer) ... ok
INFO: test_show_environment (common.CommonCompatLayer) ... ok
INFO: test_signatures (common.CommonCompatLayer) ... skipped "Layer meta-tlk isn't BSP or DISTRO one."
INFO: skipped "DistroCompatLayer: Layer meta-tlk isn't Distro one."
INFO:
INFO: ----------------------------------------------------------------------
INFO: Ran 4 tests in 2.299s
INFO:
INFO: OK (skipped=3)
INFO:
INFO: Summary of results:
INFO:
INFO: meta-intel ... PASS
INFO: meta-tlk ... PASS