Bug 11294 - create-pull-request: add in-reply-to option to ensure patch/series threads don't break
Summary: create-pull-request: add in-reply-to option to ensure patch/series threads do...
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: Scripts and Tools (show other bugs)
Version: 2.4
Hardware: x86 Multiple
: Medium enhancement
Target Milestone: 2.4 M1
Assignee: Jose Lamego
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-04-04 21:33 UTC by Jose Lamego
Modified: 2017-05-24 16:44 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Don't know


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Lamego 2017-04-04 21:33:25 UTC
The create-patch-request script creates patches as replies to a cover letter, in the form of an email thread. If further revisions are sent to the mailing list without referencing to the first revision, these new revisions are not identified at the mailing list as part of the original thread, but as a new thread instead.

This behavior may not be seen as an issue at the mailing list, but at the OE-Patchwork tool, where any patch or series identified as part of a thread is added to the existing series in the form of a new revision, missing references may cause to have broken threads, thus producing individual series for revisions of the same series (this is specially true if the new revision differs in patch quantity or title from the original).

The proposed solution is to add the "[-t in_reply_to]" option to the create-pull-request script (where "in_reply_to" is the original cover letter's Message-Id), to ensure that the reference to the original thread is added to the new patch/series so it can be identified as part of it. With this option, the cover letter for any new revision is created as reply to the original cover letter, thus ensuring that OE-Patchwork will recognize the new series as a revision of an existing one.

The "-t" option would not be required, so the current script functionality would remain the same if "-t" is missing.
Comment 1 Jose Lamego 2017-04-04 21:46:28 UTC
Proposed patch can be viewed at:
http://lists.openembedded.org/pipermail/openembedded-core/2017-April/135165.html
Comment 2 Jose Lamego 2017-04-05 19:44:45 UTC
Patch v2 can be seen at:
http://lists.openembedded.org/pipermail/openembedded-core/2017-April/135237.html

thanks for the feedback Leo.
Comment 3 Jose Lamego 2017-05-24 16:44:06 UTC
The requested functionality is provided in commit:
f7c2ec9f8719ee37bdca866c881ca5d853f9aefc