Bug 11302 - IMAGE_DEPENDS_* are added to do_rootfs[depends]
Summary: IMAGE_DEPENDS_* are added to do_rootfs[depends]
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: Scripts and Tools (show other bugs)
Version: 2.0.3
Hardware: All Multiple
: Medium normal
Target Milestone: 2.4
Assignee: Ed Bartosh
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-04-06 12:09 UTC by Ola Nilsson
Modified: 2017-06-29 07:59 UTC (History)
1 user (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Yes (doc changes required)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ola Nilsson 2017-04-06 12:09:28 UTC
The IMAGE_DEPENDS variable can be overriden to add dependencies for individual image types.  Those dependencies are added to the do_rootfs task, while they really should be added to the specific image type tasks.

Also, the IMAGE_DEPENDS variable is not documented anywhere.
Comment 1 Richard Purdie 2017-04-06 15:24:20 UTC
I did look and the code in image_types.bbclass does indeed put the dependencies onto do_rootfs rather than the specific image creation tasks.

I think we want to move to a model where these tasks have explicit dependencies, e.g. instead of IMAGE_DEPENDS_jffs2 = "mtd-utils-native" we'd have do_image_jffs2[depends] += "mtd-utils-native:do_populate_sysroot".

Since we're into feature freeze, I'm not sure how far we want to change things at this point in the release cycle and this may well need to be a 2.4 M1 activity. The end result may be the deprecation and removal of IMAGE_DEPENDS.
Comment 2 Ola Nilsson 2017-04-07 07:28:30 UTC
I guess the rootfs dependencies are leftovers from the switch to the separated image tasks. 

I kind of like the way I can add just recipe names without the :do_populate_sysroot, but I can see the point in eliminating this set of variables.

Anyway, it can certainly wait until 2.4.
Comment 3 Ed Bartosh 2017-06-15 12:06:05 UTC
Replaced usage of IMAGE_DEPENDS with explicitly added
dependencies to do_image_<image type> tasks: http://lists.openembedded.org/pipermail/openembedded-core/2017-June/138217.html
Comment 4 Ola Nilsson 2017-06-15 12:59:45 UTC
Looks good to me.
Comment 5 Ed Bartosh 2017-06-16 14:19:34 UTC
Surprisingly I manage to get to v4 so far :)
http://lists.openembedded.org/pipermail/openembedded-core/2017-June/138386.html
Comment 7 Ed Bartosh 2017-06-29 07:59:37 UTC
The fix has been accepted to poky master. Commit id: f93d58378fb4095a18c1403de03ca0e13ce465cd