Bug 11393 - recipetool: create: handle git URLs specifying only a tag
Summary: recipetool: create: handle git URLs specifying only a tag
Status: VERIFIED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: Scripts and Tools (show other bugs)
Version: 2.2
Hardware: x86 Multiple
: Medium+ minor
Target Milestone: 2.5 M1
Assignee: Rebecca Chang
QA Contact: Shashwat Pandey
URL:
Whiteboard:
Depends on: 11389
Blocks:
  Show dependency tree
 
Reported: 2017-04-20 04:10 UTC by Paul Eggleton
Modified: 2018-01-03 05:46 UTC (History)
7 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Eggleton 2017-04-20 04:10:21 UTC
If you specify tag= for a git URL passed to recipetool create, assuming the tag is valid we should just handle that correctly instead of producing a somewhat unhelpful error:

------------- snip -------------
$ devtool add --version 2.4.2 mbedtls "git://github.com/ARMmbed/mbedtls;tag=mbedtls-2.4.2"
NOTE: Fetching git://github.com/ARMmbed/mbedtls;tag=mbedtls-2.4.2...
ERROR: Fetcher failure: Conflicting revisions (AUTOINC from SRCREV and mbedtls-2.4.2 from the url) found, please specify one valid value
ERROR: Command 'script -e -q -c "recipetool --color=always create --devtool -o /tmp/devtooluvbysixx 'git://github.com/ARMmbed/mbedtls;tag=mbedtls-2.4.2'  -x /home/paul/poky/poky/build/workspace/sources/devtoolsrcmo5rjnrp -N mbedtls -V 2.4.2" /dev/null' failed
------------- snip -------------
Comment 2 Stanley Phoong 2017-07-20 12:19:41 UTC
Re-submitted into mailing list under patch series together with patch dependencies
http://lists.openembedded.org/pipermail/openembedded-core/2017-July/139885.html
Comment 3 Rebecca Chang 2017-08-23 08:16:25 UTC
OE-Core rev: 3afdcbdc9a3e65bc925ec61717784ffec67d529d
Comment 4 Rebecca Chang 2017-10-12 01:58:50 UTC
Issue still valid with devtool.
Please check/verify using the command recommended in description.
Comment 5 Rebecca Chang 2017-11-14 02:30:07 UTC
[RFC] Propose implementation by dropping "tag=" from SRC_URI.

http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rebeccas/11393-recipetool-tag&id=442fe6a8d5aceca70e0f9c135ac727d60608f950
Comment 6 Rebecca Chang 2017-11-15 02:38:25 UTC
Pushed patch to mailing list:
http://lists.openembedded.org/pipermail/openembedded-core/2017-November/144422.html
Comment 7 Rebecca Chang 2017-12-19 06:43:30 UTC
OE-Core rev: 53f8effa3eb07dc7035ff9933e7918318f242579
Poky rev: 05bcd72f9f6fb89d853a74d6fbb7becdfb06db84
Comment 8 Shashwat Pandey 2018-01-03 05:46:52 UTC
Verified, issue is fixed. 

Verification Logs: 

$ devtool add --version 2.4.2 mbedtls 
"git://github.com/ARMmbed/mbedtls;tag=mbedtls-2.4.2"

NOTE: Starting bitbake server...
NOTE: Creating workspace layer in /workdir/build/workspace
NOTE: Starting bitbake server...
NOTE: Fetching git://github.com/ARMmbed/mbedtls;nobranch=1...
Parsing recipes: 100% |############################################################################################################################################################| Time: 0:00:02
Parsing of 804 .bb files complete (0 cached, 804 parsed). 1254 targets, 37 skipped, 0 masked, 0 errors.
Removing 41 recipes from the x86_64 sysroot: 100% |################################################################################################################################| Time: 0:00:33
Removing 5 recipes from the allarch sysroot: 100% |################################################################################################################################| Time: 0:00:06
Removing 102 recipes from the core2-64 sysroot: 100% |#############################################################################################################################| Time: 0:04:49
Removing 108 recipes from the genericx86-64 sysroot: 100% |########################################################################################################################| Time: 0:00:31
NOTE: Resolving any missing task queue dependencies

Build Configuration:
BB_VERSION           = "1.37.0"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "universal"
TARGET_SYS           = "x86_64-poky-linux"
MACHINE              = "genericx86-64"
DISTRO               = "poky-lsb"
DISTRO_VERSION       = "2.4+snapshot-20180102"
TUNE_FEATURES        = "m64 core2"
TARGET_FPU           = ""
meta
meta-poky
meta-yocto-bsp       = "master:d18003726f561bab2ab07acf16baee074da37cdc"
workspace            = "<unknown>:<unknown>"

Initialising tasks: 100% |#########################################################################################################################################################| Time: 0:00:00
NOTE: Executing RunQueue Tasks
NOTE: Tasks Summary: Attempted 2 tasks of which 0 didn't need to be rerun and all succeeded.
NOTE: Using default source tree path /workdir/build/workspace/sources/mbedtls
NOTE: Starting bitbake server...
NOTE: Recipe /workdir/build/workspace/recipes/mbedtls/mbedtls_git.bb has been automatically created; further editing may be required to make it fully functional