Bug 11437 - gstreamer: playbin visualizations broken with vaapi
Summary: gstreamer: playbin visualizations broken with vaapi
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: multimedia (show other bugs)
Version: 2.3
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.4 M3
Assignee: Maxin B. John
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-05-02 08:11 UTC by Jussi Kukkonen
Modified: 2017-08-17 10:06 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: Regression (Used to work)
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jussi Kukkonen 2017-05-02 08:11:18 UTC 
+++ This bug was initially created as a clone of Bug #11410 +++

I'm cloning this for the root cause of the bug 11410 (so we can close the original now that a workaround is in place). When this is fixed, the workaround should be removed.

playbin visualizations break the whole pipeline leading to gtk-play hanging on audio playback. This only happens with vaapi but the issue seems to be a video pixel-aspect-ratio negotiation issue: somehow the value "0/1" gets negotiated as the best one and that ends up breaking multiple elements.

This upstream bug is already closed:
https://bugzilla.gnome.org/show_bug.cgi?id=781759
but that only makes one element cope with "0/1" and there are other elements that break... real fix would probably mean preventing "0/1" from becoming the aspect ratio in the first place
Comment 1 Maxin B. John 2017-05-15 14:40:17 UTC 
As Jussi pointed out, updated fix is available here:
https://cgit.freedesktop.org/gstreamer/gstreamer-vaapi/commit/?id=b3c374e22f21613295a16745428487707b680cdc

It will be included in the gstreamer upgrade(1.12.0)
Comment 2 Maxin B. John 2017-05-16 15:02:17 UTC 
Along with this fix in gstreamer-vaapi, we also need to upgrade libva-intel-driver in meta-intel to 1.8.3.pre1 release to resolve the glitch while running visualizations using vaapisink.
Comment 3 Jussi Kukkonen 2017-05-17 07:12:59 UTC 
(In reply to comment #2)
> Along with this fix in gstreamer-vaapi, we also need to upgrade
> libva-intel-driver in meta-intel to 1.8.3.pre1 release to resolve the glitch
> while running visualizations using vaapisink.

Since the remaining issue is cosmetic (the visualizations get some weird colorspace with VA), I'd say it's fine to update gstreamer now and libva-intel-driver when 1.8.3 comes out (assuming it's not expected to be months from now).
Comment 4 Maxin B. John 2017-07-03 08:42:39 UTC 
libva-intel-driver version 1.8.3 has been released. Upgrade patches for libva and libva-intel-driver were sent to oe-core and meta-intel mailing lists:

libva-1.8.3:
 http://lists.openembedded.org/pipermail/openembedded-core/2017-June/138936.html

libva-intel-driver-1.8.3:
https://lists.yoctoproject.org/pipermail/meta-intel/2017-June/004808.html