Bug 11443 - QemuRunner: should not modify os.environ
Summary: QemuRunner: should not modify os.environ
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: deployment (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.4 M1
Assignee: Patrick Ohly
QA Contact:
URL:
Whiteboard: Backport to 2.3.1
Depends on:
Blocks:
 
Reported: 2017-05-03 10:04 UTC by Patrick Ohly
Modified: 2017-06-22 08:13 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Ohly 2017-05-03 10:04:37 UTC 
In Refkit we wrote some oe-selftest tests which use oeqa.utils.commands.runqemu() to run qemu with different DEPLOY_DIR_IMAGE values (the real one in some cases, a manually constructed one in another). The artificial directory leaked from one test to another.

I'm pretty sure now the root cause is that QemuRunner modifies the process state permanently by setting os.environ["DEPLOY_DIR_IMAGE"] and other env variables. It really shouldn't be doing that.
Comment 1 Patrick Ohly 2017-05-03 11:16:21 UTC 
Patch sent: "[PATCH] QemuRunner: avoid tainting os.environ"