Bug 11755 - patchtest-oe: test checking changes in lic_files_chcksum not failing when lacking the explanation in commit message
Summary: patchtest-oe: test checking changes in lic_files_chcksum not failing when lac...
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchtest Testsuite (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium normal
Target Milestone: 2.5 M1
Assignee: Daniela Plascencia
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-07-04 22:52 UTC by Daniela Plascencia
Modified: 2017-10-20 20:45 UTC (History)
1 user (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniela Plascencia 2017-07-04 22:52:42 UTC 
The current test already has a check that should send a failure message when the LIC_FILES_CHKSUM is modified and the explanation as to why is not present on the commit message. For some reason it is not detecting the patches lacking the explanation and not failing properly. The usage of Tinfoil may solve this issue.
Comment 1 Leonardo Sandoval Gonzalez 2017-07-18 13:57:43 UTC 
This issue may be resolved with current master-next branches which will land to master shortly.
Comment 2 Daniela Plascencia 2017-09-08 20:47:52 UTC 
(In reply to comment #1)
> This issue may be resolved with current master-next branches which will land
> to master shortly.

This issue is not present anymore considering the following:
a) Both framework and test suite are on master-next
b) Latest change on base.py: find_pn() returns PN instead of FN (PATH)
c) All metadata test cases use parse_recipe() with PN as input instead of FN

b and c are not in master-next, but certainly helped solving runtime errors and might be merged soon.
Comment 3 Daniela Plascencia 2017-09-08 20:50:32 UTC 
Changing status "IN PROGRESS REVIEW".
Comment 4 Daniela Plascencia 2017-10-20 20:45:08 UTC 
Latest changes on master solve this issue.

http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe/log/