Bug 11886 - patchwork: series info page is ugly
Summary: patchwork: series info page is ugly
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchwork (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium minor
Target Milestone: 2.5 M1
Assignee: Jose Lamego
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-08-02 08:15 UTC by Paul Eggleton
Modified: 2017-11-06 17:57 UTC (History)
1 user (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
Screenshot (71.39 KB, image/png)
2017-08-02 19:21 UTC, Paul Eggleton
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Eggleton 2017-08-02 08:15:14 UTC
The buttons/tabs at the top of the series detail page are not stylistically consistent with the rest of the site - it appears styling is actually missing.
Comment 1 Paul Eggleton 2017-08-02 19:21:59 UTC
Created attachment 3916 [details]
Screenshot

Attaching a screenshot so you can see what I mean. This is in Firefox 54.0.1 on Fedora 25.
Comment 2 Jose Lamego 2017-08-02 21:04:30 UTC
Regarding the navigation bar, the style guide can be found in previous design work by Belen Barros [1].
Regarding the little "arrow" seen in Firefox (FF) and some Internet Explorer (IE) versions, a fix may be the use of "-moz-appearance:none" and "::-ms-expand" pseudo-element, respectively.

[1] http://belenbarrospena.github.io/patchwork-redesign/
    https://github.com/belenbarrospena/patchwork-redesign/tree/master
Comment 3 Jose Lamego 2017-09-06 15:59:15 UTC
I've submitted a patch that handles the "Revision" select element styling due to incompatibilities of Firefox and Internet Explorer browsers with the Boostrap library. The patch can be viewed at:
https://lists.yoctoproject.org/pipermail/yocto/2017-September/037777.html

Remaining item is to define if style guide for patchwork will be to adhere to that of freedesktop's instance or to Belen's design and implement any needed changes.
Comment 4 Jose Lamego 2017-09-07 01:41:30 UTC
The change to add "active" styling to Series data bar can be seen at:
https://lists.yoctoproject.org/pipermail/yocto/2017-September/037783.html

and an implementation example at the staging instance:
https://patchwork-staging.openembedded.org/series/6357/
Comment 5 Jose Lamego 2017-09-11 20:25:36 UTC
This change is implemented in production.