Bug 11887 - patchwork: series page shows cover letter tab by default even if no cover letter
Summary: patchwork: series page shows cover letter tab by default even if no cover letter
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchwork (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium enhancement
Target Milestone: 2.4 M4
Assignee: Jose Lamego
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-08-02 10:08 UTC by Paul Eggleton
Modified: 2017-09-11 14:39 UTC (History)
0 users

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Eggleton 2017-08-02 10:08:01 UTC 
If there's no cover letter for a series, Patchwork still shows you the cover letter tab first when you go to the series detail which is pretty useless - ideally it would take you to the patch list for the series in that case, with some minor visual indication that there's no cover letter (perhaps grey the tab or something like that, alternative ideas welcome).
Comment 1 Jose Lamego 2017-09-07 01:38:56 UTC 
Fix can be seen at:
https://lists.yoctoproject.org/pipermail/yocto/2017-September/037782.html

and implementation example at staging instance:
https://lists.yoctoproject.org/pipermail/yocto/2017-September/037782.html
Comment 2 Jose Lamego 2017-09-11 14:39:29 UTC 
Change is now implemented in production instance.