Bug 11947 - devtool upgrade needs to have some git configs set to get correct results
Summary: devtool upgrade needs to have some git configs set to get correct results
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: devtools / tool chain (show other bugs)
Version: 2.4
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 2.4 M4
Assignee: Paul Eggleton
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-08-18 00:53 UTC by brian avery
Modified: 2017-09-12 10:21 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description brian avery 2017-08-18 00:53:50 UTC 
if user.email & user.name are not set, some of the git commands that devtool upgrade runs result in erroneous behaviour. we should probably check these settings when running an upgrade.  I'm not sure if any of the other devtool features need this to be set as well.
Comment 1 Paul Eggleton 2017-08-31 22:52:44 UTC 
I sent out a patch for this but it wasn't merged - reason being it breaks oe-selftest on the autobuilder where git isn't configured. I'm not entirely sure what to do about this - the autobuilder shouldn't need git configured, but we don't want oe-selftest to be messing with the user's git configuration either. Still thinking about it.
Comment 2 Paul Eggleton 2017-09-12 10:21:44 UTC 
The autobuilder configurations were fixed to have these values set, and thus the patch got merged to master:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=6426136655cb00996c1870e2075a57716bfba846