Bug 11948 - devtool upgrade walks the file tree and execs a git add for each file
Summary: devtool upgrade walks the file tree and execs a git add for each file
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: devtools / tool chain (show other bugs)
Version: 2.4
Hardware: x86 Multiple
: Medium enhancement
Target Milestone: 2.5
Assignee: Paul Eggleton
QA Contact:
URL:
Whiteboard:
: 12198 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-08-18 01:01 UTC by brian avery
Modified: 2017-11-12 19:56 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description brian avery 2017-08-18 01:01:17 UTC
In a complex upgrade like qemu 2.8.1.1 -> 2.10.o-rc2, this can take ~ 10 minutes.  Right now, there is no user feedback that progress is being made unless devtool is run with -d. Instead, it looks like devtool upgrade has hung.

We should probably do a progress bar regardless since even if we speed it up a huge (webkit?) upgrade may still be slow. We may also want to look at other ways to do this like using the python git library instead of system calls, or doing some batching of our own, ...
The "culprit" is in scripts/lib/devtool/upgrade.py:
        (stdout,_) = __run('git ls-files --modified --others --exclude-standard')   
        for f in stdout.splitlines():                                                                                                
           __run('git add "%s"' % f)
Comment 1 Alexander Kanavin 2017-10-09 11:04:39 UTC
*** Bug 12198 has been marked as a duplicate of this bug. ***