Bug 1220 - [HOB] lots of error printed when existing from configuration save dialog
Summary: [HOB] lots of error printed when existing from configuration save dialog
Status: VERIFIED FIXED
Alias: None
Product: Hob
Classification: Build System, Metadata & Runtime
Component: hob (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: High normal
Target Milestone: 1.1 M2
Assignee: Joshua Lock - Disabled
QA Contact:
URL:
Whiteboard: Patch out for review
Depends on:
Blocks:
 
Reported: 2011-07-07 00:59 UTC by Jiajun Xu
Modified: 2011-07-10 23:18 UTC (History)
6 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiajun Xu 2011-07-07 00:59:54 UTC 
Tree/Branch: Poky/Master
Commit: d4132fa12885fc050313a5c9aa6903e4fa92c94f


When clicking exit button of hob, it will prompt if you want to save customisations. If we choose yes and choose no in save configuration dialog, bitbake will print a lot of error log as below:

#######
Traceback (most recent call last):
  File "/home/jxu49/osel/poky-hob/bitbake/lib/bb/ui/hob.py", line 91, in destroy_window
    self.quit()
  File "/home/jxu49/osel/poky-hob/bitbake/lib/bb/ui/hob.py", line 106, in quit
    self.save_recipe_file()
  File "/home/jxu49/osel/poky-hob/bitbake/lib/bb/ui/hob.py", line 315, in save_recipe_file
    rep.writeRecipe(self.save_path, self.model)
  File "/home/jxu49/osel/poky-hob/bitbake/lib/bb/ui/crumbs/tasklistmodel.py", line 68, in writeRecipe
    if os.path.exists(writepath):
  File "/usr/lib/python2.6/genericpath.py", line 18, in exists
    st = os.stat(path)
TypeError: coercing to Unicode: need string or buffer, NoneType found
#######
Comment 1 Joshua Lock - Disabled 2011-07-08 10:20:42 UTC 
Fixed in BitBake master: 3412fbd6a16980e0fba7742c32675eea9d77d6c0

"lib/bb/ui/hob: don't error when dismissing save as dialog

If the user decides to cancel the save as dialog we should not try and save
regardless.

Fixes [YOCTO #1220]"
Comment 3 Jiajun Xu 2011-07-10 23:18:09 UTC 
Verify with commit f974868cadf74d0cf8380b2c6a4152d2fa4590b5, the bug is fixed.