Bug 1222 - [HOB] Need more informative text in the build complete dialog
Summary: [HOB] Need more informative text in the build complete dialog
Status: VERIFIED FIXED
Alias: None
Product: Hob
Classification: Build System, Metadata & Runtime
Component: hob (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.1 M3
Assignee: Joshua Lock - Disabled
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2011-07-07 01:36 UTC by Jiajun Xu
Modified: 2011-08-01 23:10 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiajun Xu 2011-07-07 01:36:58 UTC 
Tree/Branch: Poky/Master
Commit: d4132fa12885fc050313a5c9aa6903e4fa92c94f

If I choose some packages or images in hob and start building, then click "Stop Build", there will be 3 options for me - "Cancel", "Stop" and "Force Stop". If I choose "Force Stop", hob will prompt a dialog to ask me if want to view log or edit image. If I choose view log, nothing will be poped up.
Comment 1 Joshua Lock - Disabled 2011-07-07 10:19:46 UTC 
I assume this is because you've forced stop before the build has actually started?

Or is this behaviour different than if Stop -> View Log are chosen?
Comment 2 Jiajun Xu 2011-07-07 17:32:48 UTC 
(In reply to comment #1)
> I assume this is because you've forced stop before the build has actually
> started?
> Or is this behaviour different than if Stop -> View Log are chosen?

Oh, seems I mis-understood the logic before. I used to think "view log" button should show more detailed information or flush the build log page.
In my testing, if in the build log page, click "view log" button will just exit the dialog and I mis-understood there should be something different shown up.

Do you think it a INVALID bug?
BTW, "Stop" button sometimes could not work. Could you describe a little what's the difference between "Stop" and "Force Stop"?
Comment 3 Joshua Lock - Disabled 2011-07-07 18:15:45 UTC 
I think the bug is probably valid but the fix may be that we change the wording. View build output?

The Stop button does work however what it does is tell BitBake to finish as soon as is safe to do so, which means any currently running tasks will be finished cleanly and then the build will stop (equivalent of Ctrl-C and then wait in the knotty, command-line, ui).
Force Stop immediately kills everything (equivalent of Ctrl-C (3?) times, until the build stops) which is why it leaves the build in a sorry state.

We definitely need to work out how to handle this...
Comment 4 Jiajun Xu 2011-07-07 19:34:14 UTC 
(In reply to comment #3)
> I think the bug is probably valid but the fix may be that we change the
> wording. View build output?

Agree. We should change the name here.

> The Stop button does work however what it does is tell BitBake to finish as
> soon as is safe to do so, which means any currently running tasks will be
> finished cleanly and then the build will stop (equivalent of Ctrl-C and then
> wait in the knotty, command-line, ui).
> Force Stop immediately kills everything (equivalent of Ctrl-C (3?) times, until
> the build stops) which is why it leaves the build in a sorry state.
> We definitely need to work out how to handle this...

I see it now. Thanks for detailed description.
Comment 6 Jiajun Xu 2011-08-01 23:10:30 UTC 
verify the bug as fixed with commit 46cf540e63a848512617b20fd8492f81bfb2f704.