Bug 12258 - LICENSE in packagegroup?
Summary: LICENSE in packagegroup?
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 2.4
Hardware: x86 Multiple
: Medium enhancement
Target Milestone: 2.5
Assignee: Ross Burton
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2017-10-20 13:42 UTC by Robert Berger
Modified: 2017-11-06 17:38 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Don't know

Attachments
proposed patch (920 bytes, patch)
2017-10-26 15:31 UTC, Robert Berger 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Berger 2017-10-20 13:42:54 UTC 
in poky:

$find | grep packagegroup | grep .bb | xargs grep LICENSE

./meta/classes/packagegroup.bbclass:LICENSE ?= "MIT"
./meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb:LICENSE = "MIT"

I am not sure what meaning e.g. in nativesdk-packagegroup-sdk-host.bb the LICENSE field has.

I guess it could be removed.

Also please check the bbclass. Is LICENSE needed there?
Comment 1 Ross Burton 2017-10-20 14:25:23 UTC 
All recipes need a license and the default is INVALID so the class sets a default value that is likely good (as packagegroups are just metapackages).

Yes the LICENS in sdk-host can be removed as it is redundant.  Want to send a patch?
Comment 2 Stephen K Jolley 2017-10-26 14:36:31 UTC 
Please answer Ross's question.
Comment 3 Robert Berger 2017-10-26 15:31:42 UTC 
Created attachment 4105 [details]
proposed patch
Comment 4 Stephen K Jolley 2017-10-27 18:27:55 UTC 
Ross,

It appears the question has been answered.  If not please restate the question and put it back in NEEDINFO.

Thanks,
Comment 5 Ross Burton 2017-10-30 12:00:05 UTC 
Patches go to the mailing list, please.
Comment 6 Robert Berger 2017-10-30 13:52:25 UTC 
Just sent it to the mailing list.
Comment 7 Robert Berger 2017-11-03 17:08:45 UTC 
It made it into oe patchwork:

https://patchwork.openembedded.org/series/9539/

Now it's resting there;)
Comment 8 Ross Burton 2017-11-06 17:38:52 UTC 
Merged in oe-core c04ae17f439ffd5fd70d8564430a94582e2cf688.